Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NIFI-11224: Refactor and FF attribute support in WHERE in QuerySalesf… #7019

Closed
wants to merge 4 commits into from
Closed

NIFI-11224: Refactor and FF attribute support in WHERE in QuerySalesf… #7019

wants to merge 4 commits into from

Conversation

Lehel44
Copy link
Contributor

@Lehel44 Lehel44 commented Mar 7, 2023 •
edited
Loading

…orceObject.

Summary

NIFI-11224

Tracking

Please complete the following tracking steps prior to pull request creation.

Issue Tracking

Pull Request Tracking

  • Pull Request title starts with Apache NiFi Jira issue number, such as NIFI-00000
  • Pull Request commit message starts with Apache NiFi Jira issue number, as such NIFI-00000

Pull Request Formatting

  • Pull Request based on current revision of the main branch
  • Pull Request refers to a feature branch with one commit containing changes

Verification

Please indicate the verification steps performed prior to pull request creation.

Build

  • Build completed using mvn clean install -P contrib-check
    • JDK 11
    • JDK 17

Licensing

  • New dependencies are compatible with the Apache License 2.0 according to the License Policy
  • New dependencies are documented in applicable LICENSE and NOTICE files

Documentation

  • Documentation formatting appears as expected in rendered files

@krisztina-zsihovszki
Copy link
Contributor

Will review.

@tpalfy
Copy link
Contributor

tpalfy commented Apr 24, 2023

Certain property changes should probably trigger a state reset.

@asfgit asfgit closed this in c819c4d Apr 26, 2023
@tpalfy
Copy link
Contributor

tpalfy commented Apr 26, 2023

LGTM
Thank you for your work @Lehel44 !
Merged into main.

asfgit pushed a commit that referenced this pull request Apr 26, 2023
@pvillard31 @Lehel44 @tpalfy
NIFI-11224: Refactor and FF attribute support in WHERE in QuerySalesf…
d52e097 
…orceObject.

This closes #7019.

Co-authored-by: Lehel Boér <lehel44@hotmail.com>
Signed-off-by: Tamas Palfy <tpalfy@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krisztina-zsihovszki krisztina-zsihovszki krisztina-zsihovszki left review comments

@tpalfy tpalfy tpalfy left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Lehel44 @krisztina-zsihovszki @tpalfy @pvillard31