Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NIFI-11407 - Upgrade Azure BOM to 1.2.11 #7136

Closed
wants to merge 2 commits into from

Conversation

pvillard31
Copy link
Contributor

Summary

NIFI-11407
Upgrade Azure bom dependency from 1.2.9 to 1.2.11

Tracking

Please complete the following tracking steps prior to pull request creation.

Issue Tracking

Pull Request Tracking

  • Pull Request title starts with Apache NiFi Jira issue number, such as NIFI-00000
  • Pull Request commit message starts with Apache NiFi Jira issue number, as such NIFI-00000

Pull Request Formatting

  • Pull Request based on current revision of the main branch
  • Pull Request refers to a feature branch with one commit containing changes

Verification

Please indicate the verification steps performed prior to pull request creation.

Build

  • Build completed using mvn clean install -P contrib-check
    • JDK 11
    • JDK 17

Licensing

  • New dependencies are compatible with the Apache License 2.0 according to the License Policy
  • New dependencies are documented in applicable LICENSE and NOTICE files

Documentation

  • Documentation formatting appears as expected in rendered files

Copy link
Contributor

@exceptionfactory exceptionfactory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The automated builds on Linux and macOS failed with what seem like unrelated errors, however, all of them fail in the same place during XML migration comparison. The issue could be related to a transitive dependency on some XML library such as Woodstox. Further evaluation is necessary to track the reason for the differences.

@exceptionfactory exceptionfactory changed the title NIFI-11407 - Upgrade Azure bom dependency NIFI-11407 - Upgrade Azure BOM to 1.2.11 Apr 10, 2023
@exceptionfactory
Copy link
Contributor

@pvillard31 After some additional evaluation, apparently the recent Azure SDK updates removed the direct dependency on Woodstox. However, nifi-toolkit-encrypt-config had an implicit expectation of behavior based on the Woodstox dependency. Woodstox provides optimal processing as compared to the standard JRE version, and it is still included in the Toolkit assembly. I pushed a commit adding a direct dependency on Woodstox to nifi-toolkit-encrypt-config, making the expectations clear. This resolved the test issues locally, so I will plan on merging pending successful automated builds.

@pvillard31
Copy link
Contributor Author

Thanks for the investigation and review @exceptionfactory !

Copy link
Contributor

@exceptionfactory exceptionfactory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated builds passed, +1 merging

exceptionfactory pushed a commit that referenced this pull request Apr 10, 2023
- Added Woodstox Core to nifi-toolkit-encrypt-config

This closes #7136

Signed-off-by: David Handermann <exceptionfactory@apache.org>
(cherry picked from commit a148b6f)
r-vandenbos pushed a commit to r-vandenbos/nifi that referenced this pull request Apr 11, 2023
- Added Woodstox Core to nifi-toolkit-encrypt-config

This closes apache#7136

Signed-off-by: David Handermann <exceptionfactory@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants