Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NIFI-11410 - Upgrade a bunch of dependencies #7141

Closed
wants to merge 2 commits into from

Conversation

pvillard31
Copy link
Contributor

@pvillard31 pvillard31 commented Apr 8, 2023

Summary

NIFI-11410

  • com.jcraft:jsch from 0.1.54 to 0.1.55
  • io.swagger.core.v3:swagger-annotations from 2.2.8 to 2.2.9
  • com.box:box-java-sdk from 4.0.0 to 4.0.1
  • com.github.jknack:handlebars from 4.3.0 to 4.3.1
  • com.github.luben:zstd-jni from 1.5.2-3 to 1.5.5-1
  • com.sun.jersey:jersey-bundle from 1.19.3 to 1.19.4
  • org.antlr:antlr-runtime from 3.5.2 to 3.5.3
  • org.apache.ant:ant from 1.10.12 to 1.10.13
  • org.apache.commons:commons-pool2 from 2.4.1 to 2.4.3
  • org.apache.iotdb from 1.0.0 to 1.0.1
  • org.apache.kafka:connect-api from 2.6.0 to 2.6.3
  • org.apache.lucene from 8.11.1 to 8.11.2
  • org.apache.solr:solr-solrj from 8.11.1 to 8.11.2
  • org.apache.santuario:xmlsec from 2.3.1 to 2.3.3
  • org.mariadb.jdbc:mariadb-java-client from 3.1.1 to 3.1.3
  • org.springframework.boot:spring-boot-X from 2.7.9 to 2.7.10

Tracking

Please complete the following tracking steps prior to pull request creation.

Issue Tracking

Pull Request Tracking

  • Pull Request title starts with Apache NiFi Jira issue number, such as NIFI-00000
  • Pull Request commit message starts with Apache NiFi Jira issue number, as such NIFI-00000

Pull Request Formatting

  • Pull Request based on current revision of the main branch
  • Pull Request refers to a feature branch with one commit containing changes

Verification

Please indicate the verification steps performed prior to pull request creation.

Build

  • Build completed using mvn clean install -P contrib-check
    • JDK 11
    • JDK 17

Licensing

  • New dependencies are compatible with the Apache License 2.0 according to the License Policy
  • New dependencies are documented in applicable LICENSE and NOTICE files

Documentation

  • Documentation formatting appears as expected in rendered files

Copy link
Contributor

@exceptionfactory exceptionfactory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for continuing to work through these dependency upgrades @pvillard31!

The majority of these changes look good.

Can you pull out the Caffeine upgrade into a separate PR? Caffeine version 3 requires Java 11. We should move to that for the main branch, but first we should upgrade to the latest version 2 and backport the change. The centralization of the dependency management at the root level looks good, so if we could handle that in two steps, that would be ideal.

The rest of the dependency updates look good.

@pvillard31
Copy link
Contributor Author

Yep, good point!

@pvillard31
Copy link
Contributor Author

@exceptionfactory thanks for your comment about caffeine, I removed the changes from this PR and will work on two dedicated PR for this change.

Copy link
Contributor

@exceptionfactory exceptionfactory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for separating out the Caffeine upgrade @pvillard31, the rest of these incremental upgrades look good!

exceptionfactory pushed a commit that referenced this pull request Apr 10, 2023
- Upgraded Spring Boot from 2.7.9 to 2.7.10

This closes #7141

Signed-off-by: David Handermann <exceptionfactory@apache.org>

(cherry picked from commit 0160d6d)
r-vandenbos pushed a commit to r-vandenbos/nifi that referenced this pull request Apr 11, 2023
- Upgraded Spring Boot from 2.7.9 to 2.7.10

This closes apache#7141

Signed-off-by: David Handermann <exceptionfactory@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants