Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NIFI-11426 - Upgrade jline to 3.23.0 #7157

Closed
wants to merge 1 commit into from

Conversation

pvillard31
Copy link
Contributor

Summary

NIFI-11426

Upgrade jline to 3.23.0

https://github.com/jline/jline3/blob/master/changelog.md

Tracking

Please complete the following tracking steps prior to pull request creation.

Issue Tracking

Pull Request Tracking

  • Pull Request title starts with Apache NiFi Jira issue number, such as NIFI-00000
  • Pull Request commit message starts with Apache NiFi Jira issue number, as such NIFI-00000

Pull Request Formatting

  • Pull Request based on current revision of the main branch
  • Pull Request refers to a feature branch with one commit containing changes

Verification

Please indicate the verification steps performed prior to pull request creation.

Build

  • Build completed using mvn clean install -P contrib-check
    • JDK 11
    • JDK 17

Licensing

  • New dependencies are compatible with the Apache License 2.0 according to the License Policy
  • New dependencies are documented in applicable LICENSE and NOTICE files

Documentation

  • Documentation formatting appears as expected in rendered files

Copy link
Contributor

@exceptionfactory exceptionfactory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the upgrade @pvillard31. With the inclusion of updates to correct style parsing, this upgrade removes the need for the custom NiFi FileNameCompleter for the CLI. I will look into creating a separate Jira to make those changes.

+1 merging

exceptionfactory pushed a commit that referenced this pull request Apr 11, 2023
This closes #7157

Signed-off-by: David Handermann <exceptionfactory@apache.org>
(cherry picked from commit 3b216ce)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants