Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NIFI-11429 - Upgrade Gremlin to 3.6.2 #7160

Closed
wants to merge 1 commit into from

Conversation

pvillard31
Copy link
Contributor

Summary

NIFI-11429

Upgrade Gremlin to 3.6.2

https://github.com/apache/tinkerpop/blob/master/CHANGELOG.asciidoc

Tracking

Please complete the following tracking steps prior to pull request creation.

Issue Tracking

Pull Request Tracking

  • Pull Request title starts with Apache NiFi Jira issue number, such as NIFI-00000
  • Pull Request commit message starts with Apache NiFi Jira issue number, as such NIFI-00000

Pull Request Formatting

  • Pull Request based on current revision of the main branch
  • Pull Request refers to a feature branch with one commit containing changes

Verification

Please indicate the verification steps performed prior to pull request creation.

Build

  • Build completed using mvn clean install -P contrib-check
    • JDK 11
    • JDK 17

Licensing

  • New dependencies are compatible with the Apache License 2.0 according to the License Policy
  • New dependencies are documented in applicable LICENSE and NOTICE files

Documentation

  • Documentation formatting appears as expected in rendered files

@exceptionfactory
Copy link
Contributor

@mattyb149 Can you take a closer look at this particular upgrade? There was an issue with some graph databases in past versions, but this is a good opportunity to move to the latest version of the Gremlin libraries.

@MikeThomsen
Copy link
Contributor

@exceptionfactory Which databases are you talking about?

@exceptionfactory
Copy link
Contributor

Thanks for taking a look @MikeThomsen, I was referring to pull request #5284, which backed down a change from Gremlin 3.5.1 to 3.4.4. The changes apply to the nifi-other-graph-services module, so with your background on those services, are you familiar with any potential impact to supported versions?

@MikeThomsen
Copy link
Contributor

@exceptionfactory the other graph services module needs to be reexamined because its main selling point was OpenCypher support, and I'm not sure what level of support that has today.

Copy link
Contributor

@MikeThomsen MikeThomsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@exceptionfactory cypher-gremlin-neo4j-driver has not been updated for 3 years. I'm going to merge this and put up a PR to remove the OpenCypher client service because no one should be using it right now.

@asfgit asfgit closed this in 061f3a1 Apr 13, 2023
asfgit pushed a commit that referenced this pull request Apr 13, 2023
This closes #7160

Signed-off-by: Mike Thomsen <mthomsen@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants