Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NIFI-11386 Add "resource" and "audience" support for StandardOauth2AccessTokenProvider #7164

Closed
wants to merge 2 commits into from
Closed

NIFI-11386 Add "resource" and "audience" support for StandardOauth2AccessTokenProvider #7164

wants to merge 2 commits into from

Conversation

tpalfy
Copy link
Contributor

@tpalfy tpalfy commented Apr 11, 2023 •
edited
Loading

Summary

NIFI-11386

Tracking

Please complete the following tracking steps prior to pull request creation.

Issue Tracking

Pull Request Tracking

  • Pull Request title starts with Apache NiFi Jira issue number, such as NIFI-00000
  • Pull Request commit message starts with Apache NiFi Jira issue number, as such NIFI-00000

Pull Request Formatting

  • Pull Request based on current revision of the main branch
  • Pull Request refers to a feature branch with one commit containing changes

Verification

Please indicate the verification steps performed prior to pull request creation.

Build

  • Build completed using mvn clean install -P contrib-check
    • JDK 11
    • JDK 17

Licensing

  • New dependencies are compatible with the Apache License 2.0 according to the License Policy
  • New dependencies are documented in applicable LICENSE and NOTICE files

Documentation

  • Documentation formatting appears as expected in rendered files

NIFI-11386 Add "resource" and "audience" support for StandardOauth2Ac…
4513a2f 
…cessTokenProvider. Also keeping prevkous refresh token if one is not provided during a refresh request.
pvillard31
pvillard31 requested changes Apr 12, 2023
View reviewed changes
Copy link
Contributor

@pvillard31 pvillard31 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The two new properties should be added to private static final List<PropertyDescriptor> PROPERTIES, no?

pvillard31
pvillard31 approved these changes Apr 17, 2023
View reviewed changes
Copy link
Contributor

@pvillard31 pvillard31 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, @exceptionfactory do you also want to have a look?

exceptionfactory
exceptionfactory approved these changes Apr 18, 2023
View reviewed changes
Copy link
Contributor

@exceptionfactory exceptionfactory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the improvements @tpalfy, the new properties are helpful, and the additional check for updating the Refresh Token looks good with the new unit tests.

Thanks for the review @pvillard31!

+1 merging

exceptionfactory pushed a commit that referenced this pull request Apr 18, 2023
@exceptionfactory
NIFI-11386 Added Resource and Audience support to StandardOauth2Acces…
39c7a35 
…sTokenProvider

- Also keeping previous Refresh Token if one is not provided during a refresh request

This closes #7164

Signed-off-by: David Handermann <exceptionfactory@apache.org>
(cherry picked from commit 88587f5)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@exceptionfactory exceptionfactory exceptionfactory approved these changes

@pvillard31 pvillard31 pvillard31 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tpalfy @pvillard31 @exceptionfactory