NIFI-11440: Speed up Hive Metastore based unit tests

[mark-bathori]

Summary

NIFI-11440

Tracking

Please complete the following tracking steps prior to pull request creation.

Issue Tracking

• Apache NiFi Jira issue created

Pull Request Tracking

• Pull Request title starts with Apache NiFi Jira issue number, such as NIFI-00000
• Pull Request commit message starts with Apache NiFi Jira issue number, as such NIFI-00000

Pull Request Formatting

• Pull Request based on current revision of the main branch
• Pull Request refers to a feature branch with one commit containing changes

Verification

Please indicate the verification steps performed prior to pull request creation.

Build

• Build completed using mvn clean install -P contrib-check
  • JDK 11
  • JDK 17

Licensing

• New dependencies are compatible with the Apache License 2.0 according to the License Policy
• New dependencies are documented in applicable LICENSE and NOTICE files

Documentation

• Documentation formatting appears as expected in rendered files

[exceptionfactory]

Thanks for the optimization @mark-bathori! The general approach looks good. The only problem is that the ThriftMetastore.beforeAll() method fails on Windows due to a path issue. It would be help to correct this so that the test can run on all platforms, but if that is not an option, the best approach seems to be promoting the DisabledOnOs annotation to the class level.

[joewitt]

I would advise not to waste any time bothering with these tests on Windows. I'd just detect running on windows and ignore them.

[exceptionfactory]

I would advise not to waste any time bothering with these tests on Windows. I'd just detect running on windows and ignore them.

I concur, the tests are already disabled on Windows, so promoting the annotation from method level to class level seems like the best path forward.

[mark-bathori]

Thanks @exceptionfactory for the review. I overlooked that the modified AfterAll would be still called if every test case is ignored on method level. I moved the DisabledOnOs annotation to class level.

[exceptionfactory]

Thanks for making the adjustments @mark-bathori! I started the automated build and will plan on merging pending successful completion on all platforms.

[exceptionfactory]

Build success on all platforms, thanks @mark-bathori! +1 merging