Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NIFI-11439 - GCS processors; expose config of custom client endpoint #7172

Closed
wants to merge 3 commits into from
Closed

NIFI-11439 - GCS processors; expose config of custom client endpoint #7172

wants to merge 3 commits into from

Conversation

greyp9
Copy link
Contributor

@greyp9 greyp9 commented Apr 13, 2023

Summary

NIFI-11439

Tracking

Please complete the following tracking steps prior to pull request creation.

Issue Tracking

Pull Request Tracking

  • Pull Request title starts with Apache NiFi Jira issue number, such as NIFI-00000
  • Pull Request commit message starts with Apache NiFi Jira issue number, as such NIFI-00000

Pull Request Formatting

  • Pull Request based on current revision of the main branch
  • Pull Request refers to a feature branch with one commit containing changes

Verification

Please indicate the verification steps performed prior to pull request creation.

Build

  • Build completed using mvn clean install -P contrib-check
    • JDK 11
    • JDK 17

Licensing

  • New dependencies are compatible with the Apache License 2.0 according to the License Policy
  • New dependencies are documented in applicable LICENSE and NOTICE files

Documentation

  • Documentation formatting appears as expected in rendered files

exceptionfactory
exceptionfactory requested changes Apr 13, 2023
View reviewed changes
Copy link
Contributor

@exceptionfactory exceptionfactory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for introducing the new property @greyp9. The general approach looks good, but I noted an additional point regarding the HTTP Host header based on the Google Private Service Connect documentation. It also looks like the property descriptor could be added to the abstract class.

...e/nifi-gcp-processors/src/main/java/org/apache/nifi/processors/gcp/AbstractGCPProcessor.java Outdated Show resolved Hide resolved
...ifi-gcp-processors/src/main/java/org/apache/nifi/processors/gcp/storage/DeleteGCSObject.java Outdated Show resolved Hide resolved
...cp-processors/src/main/java/org/apache/nifi/processors/gcp/storage/AbstractGCSProcessor.java Outdated Show resolved Hide resolved
exceptionfactory
exceptionfactory approved these changes Apr 13, 2023
View reviewed changes
Copy link
Contributor

@exceptionfactory exceptionfactory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making the adjustments @greyp9, the latest version looks good. +1 merging

exceptionfactory pushed a commit that referenced this pull request Apr 13, 2023
@greyp9 @exceptionfactory
NIFI-11439 Added Storage API URL property to GCS Processors
7afe09a 
- Included Host Header override with Storage API URL based on Google Private Service Connect documentation

This closes #7172

Signed-off-by: David Handermann <exceptionfactory@apache.org>
(cherry picked from commit ee24df2)
@pvillard31 pvillard31 mentioned this pull request Jul 5, 2023
Closed
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@exceptionfactory exceptionfactory exceptionfactory approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@greyp9 @exceptionfactory