NIFI-11439 - correct provenance reporting parameter

[greyp9]

In previous PR, missed adjustment of URL supplied to provenance reporting subsystem.

Summary

NIFI-11439

Tracking

Please complete the following tracking steps prior to pull request creation.

Issue Tracking

• Apache NiFi Jira issue created

Pull Request Tracking

• Pull Request title starts with Apache NiFi Jira issue number, such as NIFI-00000
• Pull Request commit message starts with Apache NiFi Jira issue number, as such NIFI-00000

Pull Request Formatting

• Pull Request based on current revision of the main branch
• Pull Request refers to a feature branch with one commit containing changes

Verification

Please indicate the verification steps performed prior to pull request creation.

Build

• Build completed using mvn clean install -P contrib-check
  • JDK 11
  • JDK 17

Licensing

• New dependencies are compatible with the Apache License 2.0 according to the License Policy
• New dependencies are documented in applicable LICENSE and NOTICE files

Documentation

• Documentation formatting appears as expected in rendered files

[exceptionfactory]

Thanks for addressing the Provenance Transit URI construction @greyp9. The strategy makes sense, just recommend an approach based on URI instead of URL construction.

[exceptionfactory]

Using URI.create() avoids the checked MalformedURLException and because the Storage API URL must be valid for making the request, recommend the following approach:

Suggested change

	String transitUri;
	try {
	final URL url = new URL(storage.getOptions().getHost());
	transitUri = String.format("%s://%s.%s/%s", url.getProtocol(), bucketName, url.getHost(), key);
	} catch (MalformedURLException e) {
	transitUri = e.getClass().getSimpleName();
	}
	final URI storageApiUri = URI.create(storage.getOptions().getHost());
	final String transitUri = String.format("%s://%s.%s/%s", uri,getScheme(), bucketName, uri.getHost(), key);

[greyp9]

Yep, that's better.

[exceptionfactory]

It seems like the implementation could be moved to a protected getTransitUri() method in AbstractGCSProcessor, or the changed could be implemented in both classes.

Suggested change

	String transitUri;
	try {
	final URL url = new URL(storage.getOptions().getHost());
	transitUri = String.format("%s://%s.%s/%s", url.getProtocol(), bucket, url.getHost(), key);
	} catch (MalformedURLException e) {
	transitUri = e.getClass().getSimpleName();
	}
	final URI storageApiUri = URI.create(storage.getOptions().getHost());
	final String transitUri = String.format("%s://%s.%s/%s", uri,getScheme(), bucketName, uri.getHost(), key);

[exceptionfactory]

Thanks for making the adjustments and addressing the feedback @greyp9, the latest version looks good! +1 merging