NIFI-11460 Switch to JLine 3.23.0 FileNameCompleter #7175
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed project StandardFileNameCompleter no longer required as of JLine 3.23.0 which incorporated JLine Pull Request 817
pvillard31
approved these changes
Apr 18, 2023
asfgit
pushed a commit
that referenced
this pull request
Apr 18, 2023
Removed project StandardFileNameCompleter no longer required as of JLine 3.23.0 which incorporated JLine Pull Request 817 Signed-off-by: Pierre Villard <pierre.villard.fr@gmail.com> This closes #7175.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
NIFI-11460 Switches the
FileNameCompleterimplementation for the NiFi CLI from the customStandardFileNameCompleterto the JLine3Completers.FileNameCompleterimplementation.JLine 3.23.0 included changes from Pull Request 817 that corrected style parsing behavior to avoid StackOverflowErrors. The custom completer class introduced for NIFI-11048 is no longer required following to the upgrade to JLine 3.23.0 in NIFI-11426.
Tracking
Please complete the following tracking steps prior to pull request creation.
Issue Tracking
Pull Request Tracking
NIFI-00000NIFI-00000Pull Request Formatting
mainbranchVerification
Please indicate the verification steps performed prior to pull request creation.
Build
mvn clean install -P contrib-checkLicensing
LICENSEandNOTICEfilesDocumentation