Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NIFI-11457 Update commons-configuration2 to 2.9.0 #7176

Closed
wants to merge 2 commits into from
Closed

NIFI-11457 Update commons-configuration2 to 2.9.0 #7176

wants to merge 2 commits into from

Conversation

mr1716
Copy link
Contributor

@mr1716 mr1716 commented Apr 17, 2023

Summary

NIFI-11457

Tracking

Please complete the following tracking steps prior to pull request creation.

Issue Tracking

Pull Request Tracking

  • Pull Request title starts with Apache NiFi Jira issue number, such as NIFI-00000
  • Pull Request commit message starts with Apache NiFi Jira issue number, as such NIFI-00000

Pull Request Formatting

  • Pull Request based on current revision of the main branch
  • Pull Request refers to a feature branch with one commit containing changes

Verification

Please indicate the verification steps performed prior to pull request creation.

Build

  • Build completed using mvn clean install -P contrib-check
    • JDK 11
    • JDK 17

Licensing

  • New dependencies are compatible with the Apache License 2.0 according to the License Policy
  • New dependencies are documented in applicable LICENSE and NOTICE files

Documentation

  • Documentation formatting appears as expected in rendered files

exceptionfactory
exceptionfactory requested changes Apr 17, 2023
View reviewed changes
Copy link
Contributor

@exceptionfactory exceptionfactory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mr1716 Commons Configuration 2.8.0 is also configured in nifi-toolkit-encrypt-config, can you update that version as well?

@mr1716
Copy link
Contributor Author

mr1716 commented Apr 17, 2023

@exceptionfactory thanks for the heads up. Change made and file updated

@mr1716
Copy link
Contributor Author

mr1716 commented Apr 17, 2023

Everything ran successfully when I ran this locally.

exceptionfactory
exceptionfactory approved these changes Apr 17, 2023
View reviewed changes
Copy link
Contributor

@exceptionfactory exceptionfactory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the upgrade @mr1716, the changes in 2.9.0 look straightforward. +1 merging

exceptionfactory pushed a commit that referenced this pull request Apr 17, 2023
@mr1716 @exceptionfactory
NIFI-11457 Upgraded commons-configuration2 from 2.8.0 to 2.9.0
f24a070 
This closes #7176

Signed-off-by: David Handermann <exceptionfactory@apache.org>
(cherry picked from commit f776599)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@exceptionfactory exceptionfactory exceptionfactory approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mr1716 @exceptionfactory