NIFI-11466: Add ModifyCompression processor

[mattyb149]

Summary

NIFI-11466 This PR adds a ModifyCompression processor which combines the functionality of CompressContent with the ability to decompress the input then recompress the output, avoiding any disk usage between multiple CompressContent processors (decompress -> recompress) and uses sensible in-memory buffers to avoid out-of-memory errors.

Tracking

Please complete the following tracking steps prior to pull request creation.

Issue Tracking

• Apache NiFi Jira issue created

Pull Request Tracking

• Pull Request title starts with Apache NiFi Jira issue number, such as NIFI-00000
• Pull Request commit message starts with Apache NiFi Jira issue number, as such NIFI-00000

Pull Request Formatting

• Pull Request based on current revision of the main branch
• Pull Request refers to a feature branch with one commit containing changes

Verification

Please indicate the verification steps performed prior to pull request creation.

Build

• Build completed using mvn clean install -P contrib-check
  • JDK 11
  • JDK 17

Licensing

• New dependencies are compatible with the Apache License 2.0 according to the License Policy
• New dependencies are documented in applicable LICENSE and NOTICE files

Documentation

• Documentation formatting appears as expected in rendered files

[exceptionfactory]

Thanks for introducing this new Processor @mattyb149! It looks like a helpful addition and potential replacement for CompressContent. With more recent framework updates, there are a number of improvement opportunities that could be made in this implementation.

One other high level suggestion would be to move this processor out of nifi-standard-nar and into a new nifi-compress-bundle. This Processor has a lot of external dependencies that are specific to compression, so this is a good opportunity to move them out of the standard NAR and into a specialized bundle.

[exceptionfactory]

Thanks for making the updates @mattyb149. There are still a few unaddressed comments from the original round of feedback, and I noted several additional recommendations.

It looks like the unit tests are failing in the latest commit. StreamUtils.copy() does not call OutputStream.flush(), but the callback should call OutputStream.close(), not sure if that is related to the unit test problem.

[exceptionfactory]

Thanks for the latest round of updates @mattyb149. I marked most of my comments as resolved, but there are several still unaddressed, including a few related to the test class. GitHub collapses larger sets of comments, so please make sure to expanded the list to make sure they are addressed.

[exceptionfactory]

Thanks for the updates @mattyb149! I went through and did some runtime testing, and also took one more pass through the code. There were some opportunities to make more use the enum values for comparison, instead of comparing the string values, so I made some adjustments and pushed an update. The changes should be ready to go following a clean build.

[mattyb149]

+1 LGTM, thanks for the assist! Do you mind merging this after adding yourself as a co-author? Want to make sure you get credit even after the commits are squashed.

[exceptionfactory]

Thanks for the confirmation on the changes @mattyb149, will plan on merging with the Co-authored-by line soon.

[exceptionfactory]

Rebased to resolve minor conflict in nifi-assembly/pom.xml. +1 merging