NIFI-11461 Improve User and Group Tenants Search #7181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added searchTenants method to NiFiServiceFacade and removed unnecessary object creation - Updated TenantsResource to use delegated NiFiServiceFacade.searchTenants method - Changed autocomplete delay from default 300 ms to 500 ms
|
Will review... |
mcgilman
reviewed
Apr 18, 2023
There was a problem hiding this comment.
Thanks @exceptionfactory! Looks great... I verified the new behavior but did notice a minor thing we may want to update prior to merging.
| return createTenantEntity(tenant, permissions); | ||
| } | ||
|
|
||
| private TenantEntity createTenantEntity(final Group userGroup, final PermissionsDTO permissions) { |
There was a problem hiding this comment.
Our EntityFactory already contains methods for creating a TenantEntity given a tenant, revision, and permissions. Can we use that in favor of these new methods?
There was a problem hiding this comment.
Thanks for pointer to EntityFactory, I pushed an update removing the private methods and adjusting the stream function to make use of EntityFactory.createTenantEntity().
mcgilman
approved these changes
Apr 19, 2023
exceptionfactory
added a commit
that referenced
this pull request
Apr 19, 2023
* NIFI-11461 Improved User and Group Tenants Search - Added searchTenants method to NiFiServiceFacade and removed unnecessary object creation - Updated TenantsResource to use delegated NiFiServiceFacade.searchTenants method - Changed autocomplete delay from default 300 ms to 500 ms * NIFI-11461 Adjusted implementation to use EntityFactory.createTenantEntity This closes #7181 (cherry picked from commit bdff3ab)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
NIFI-11461 Improves the performance of the User and Group Tenants Search REST Resource method with the addition of a
searchTenantsmethod to theNiFiServiceFacade.The previous implementation called
getUsers()andgetUserGroups()in the Tenants Resource, which requires retrieving all users and all group members before evaluating the query.The new implementation passes the query string to the
NiFiServiceFacade.searchTenants()method and applies the filtering criteria prior to additional object creation. This approach reduces the number of method calls significantly for large numbers of users and groups.Additional changes include adjusting the user interface autocomplete delay from the default 300 ms to 500 ms, minimizing the number of HTTP requests in some scenarios.
Tracking
Please complete the following tracking steps prior to pull request creation.
Issue Tracking
Pull Request Tracking
NIFI-00000NIFI-00000Pull Request Formatting
mainbranchVerification
Please indicate the verification steps performed prior to pull request creation.
Build
mvn clean install -P contrib-checkLicensing
LICENSEandNOTICEfilesDocumentation