Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NIFI-11433 - use .add() for set instead of .push() #7193

Merged
merged 2 commits into from
Apr 25, 2023
Merged

NIFI-11433 - use .add() for set instead of .push() #7193

merged 2 commits into from
Apr 25, 2023

Conversation

scottyaslan
Copy link
Contributor

Summary

NIFI-00000

Tracking

Please complete the following tracking steps prior to pull request creation.

Issue Tracking

Pull Request Tracking

  • Pull Request title starts with Apache NiFi Jira issue number, such as NIFI-00000
  • Pull Request commit message starts with Apache NiFi Jira issue number, as such NIFI-00000

Pull Request Formatting

  • Pull Request based on current revision of the main branch
  • Pull Request refers to a feature branch with one commit containing changes

Verification

Please indicate the verification steps performed prior to pull request creation.

Build

  • Build completed using mvn clean install -P contrib-check
    • JDK 11
    • JDK 17

Licensing

  • New dependencies are compatible with the Apache License 2.0 according to the License Policy
  • New dependencies are documented in applicable LICENSE and NOTICE files

Documentation

  • Documentation formatting appears as expected in rendered files

mtien-apache
mtien-apache requested changes Apr 24, 2023
View reviewed changes
Copy link
Contributor

@mtien-apache mtien-apache left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix, @scottyaslan. add() works fine now, but I'm getting console errors for other things now.

  1. each() should be forEach().
    Screen Shot 2023-04-24 at 3 05 16 PM

  2. Looks like nest() has been deprecated as of d3 version 6 and group() is recommended instead.

    Screen Shot 2023-04-24 at 3 43 55 PM

@pvillard31 pvillard31 changed the title [NIFI-11433] use .add() for set instead of .push() NIFI-11433 - use .add() for set instead of .push() Apr 25, 2023
@scottyaslan
Copy link
Contributor Author

@mtien-apache thanks for the review. I have pushed changes to this PR. Please fetch and test again.

mtien-apache
mtien-apache approved these changes Apr 25, 2023
View reviewed changes
Copy link
Contributor

@mtien-apache mtien-apache left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the fixes, @scottyaslan!

@mtien-apache mtien-apache merged commit 387504b into apache:main Apr 25, 2023
mtien-apache pushed a commit that referenced this pull request Apr 25, 2023
@scottyaslan
NIFI-11433 - use .add() for set instead of .push() (#7193)
8d04559 
* replace d3.nest, use add instead of push for Set, use forEach to loop over Set

* es5 function syntax

Merged #7193 into main.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mtien-apache mtien-apache mtien-apache approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@scottyaslan @mtien-apache