Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NIFI-11560] call forEach on Map #7297

Merged
merged 2 commits into from
Jun 1, 2023
Merged

Conversation

scottyaslan
Copy link
Contributor

Summary

NIFI-11560

Tracking

Please complete the following tracking steps prior to pull request creation.

Issue Tracking

Pull Request Tracking

  • Pull Request title starts with Apache NiFi Jira issue number, such as NIFI-00000
  • Pull Request commit message starts with Apache NiFi Jira issue number, as such NIFI-00000

Pull Request Formatting

  • Pull Request based on current revision of the main branch
  • Pull Request refers to a feature branch with one commit containing changes

Verification

Please indicate the verification steps performed prior to pull request creation.

Build

  • Build completed using mvn clean install -P contrib-check
    • JDK 11
    • JDK 17

Licensing

  • New dependencies are compatible with the Apache License 2.0 according to the License Policy
  • New dependencies are documented in applicable LICENSE and NOTICE files

Documentation

  • Documentation formatting appears as expected in rendered files

Copy link
Contributor

@mcgilman mcgilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @scottyaslan! I've confirmed the fix but I suspect we have the same issue here [1].

nf-policy-management.js?2.0.0-SNAPSHOT:458 Uncaught TypeError: requiredPermissions.each is not a function
    at S.fn.init.select (nf-policy-management.js?2.0.0-SNAPSHOT:458:53)
    at selectOption (jquery.combo.js?2.0.0-SNAPSHOT:117:31)
    at HTMLLIElement.<anonymous> (jquery.combo.js?2.0.0-SNAPSHOT:204:37)
    at HTMLLIElement.dispatch (jquery.min.js:2:43184)
    at $event.dispatch (jquery.event.drag-2.3.0.js:387:30)
    at y.handle (jquery.min.js:2:41168)

[1] https://github.com/apache/nifi/blob/main/nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-ui/src/main/webapp/js/nf/canvas/nf-policy-management.js#L458

@scottyaslan scottyaslan requested a review from mcgilman May 31, 2023 20:21
Copy link
Contributor

@mcgilman mcgilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @scottyaslan

@mcgilman mcgilman merged commit 7a10ba6 into apache:main Jun 1, 2023
asfgit pushed a commit that referenced this pull request Jun 1, 2023
* [NIFI-11560] call forEach on Map

* getComponentRestrictions returns Map, use forEach

This closes #7297
@mosermw
Copy link
Member

mosermw commented Jun 1, 2023

Thanks all! I also verified the first commit resolves the ReportingTask bulletin issue in both 1.22.0-SNAPSHOT and 2.0.0-SNAPSHOT.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants