Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NIFI-11621: Handle the case of CHOICE fields when inferring the type … #7322

Closed
wants to merge 1 commit into from

Conversation

markap14
Copy link
Contributor

…of ARRAY elements. E.g., support ARRAY<CHOICE<STRING, NULL>>

Summary

NIFI-00000

Tracking

Please complete the following tracking steps prior to pull request creation.

Issue Tracking

Pull Request Tracking

  • Pull Request title starts with Apache NiFi Jira issue number, such as NIFI-00000
  • Pull Request commit message starts with Apache NiFi Jira issue number, as such NIFI-00000

Pull Request Formatting

  • Pull Request based on current revision of the main branch
  • Pull Request refers to a feature branch with one commit containing changes

Verification

Please indicate the verification steps performed prior to pull request creation.

Build

  • Build completed using mvn clean install -P contrib-check
    • JDK 11
    • JDK 17

Licensing

  • New dependencies are compatible with the Apache License 2.0 according to the License Policy
  • New dependencies are documented in applicable LICENSE and NOTICE files

Documentation

  • Documentation formatting appears as expected in rendered files

…of ARRAY elements. E.g., support ARRAY<CHOICE<STRING, NULL>>
@markap14 markap14 marked this pull request as ready for review May 31, 2023 20:00
@mattyb149
Copy link
Contributor

Reviewing...

@mattyb149
Copy link
Contributor

+1 LGTM, tested various nested array scenarios, all were inferred correctly. Thanks for the fix! Merging to 1.x and main

@mattyb149 mattyb149 closed this in ac81067 May 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants