Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NIFI-12376: Fix logic error with bitwise operator in AvroReader #8034

Closed
wants to merge 1 commit into from

Conversation

mattyb149
Copy link
Contributor

Summary

NIFI-12376 This PR simply replaces a bitwise AND with a logical AND. There is no unit test at the time of PR creation because the logic is easily verified and cannot regress, as bitwise operators do not "short-circuit" and logical operators do.

Tracking

Please complete the following tracking steps prior to pull request creation.

Issue Tracking

Pull Request Tracking

  • Pull Request title starts with Apache NiFi Jira issue number, such as NIFI-00000
  • Pull Request commit message starts with Apache NiFi Jira issue number, as such NIFI-00000

Pull Request Formatting

  • Pull Request based on current revision of the main branch
  • Pull Request refers to a feature branch with one commit containing changes

Verification

Please indicate the verification steps performed prior to pull request creation.

Build

  • Build completed using mvn clean install -P contrib-check
    • JDK 21

Licensing

  • New dependencies are compatible with the Apache License 2.0 according to the License Policy
  • New dependencies are documented in applicable LICENSE and NOTICE files

Documentation

  • Documentation formatting appears as expected in rendered files

@asfgit asfgit closed this in 685c686 Nov 15, 2023
asfgit pushed a commit that referenced this pull request Nov 15, 2023
Signed-off-by: Pierre Villard <pierre.villard.fr@gmail.com>

This closes #8034.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants