NIFI-2503 Backport PostHTTP SSL Protocol fix to 0.x branch #811
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ts into and persists keystore, starts embedded HTTPS Jetty server, connects, and verifies response. Currently only TLSv1.2 connections are successful because of the overlap of cipher suites. Will manually insert cipher suites into server for TLSv1 and TLSv1.1 support.
…nstruction of SSLSocketFactory to avoid hardcoding supported protocol. Added integration tests (2 of 4 pass -- TLSv1.2 is supported on my machine but TLSv1 and TLSv1.1 are not).
…protocol setting. Tests pass (require cleanup). Previously, dynamically-generated keystores with only RSA certificates were not acceptable for TLSv1 or TLSv1.1 connections which required DSA/DSS cipher suites for some reason.
asfgit
pushed a commit
that referenced
this pull request
Aug 9, 2016
|
@jskora I merged to 0.x, thanks. Could you close this PR manually? |
|
Thanks @pvillard31 for committing this. It looks like you put the "this closes..." comment on it, any idea why it didn't close automatically? |
|
@jskora it only works when merging to master branch ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge changes from NIFI-1688 / PR-624 into 0.x branch.
Changes apply cleanly and test without problem.