Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NIFI-13045 Provide an option to specify the bootstrap listen port #8648

Closed
wants to merge 1 commit into from

Conversation

briansolo1985
Copy link
Contributor

Summary

NIFI-13045

Tracking

Please complete the following tracking steps prior to pull request creation.

Issue Tracking

Pull Request Tracking

  • Pull Request title starts with Apache NiFi Jira issue number, such as NIFI-00000
  • Pull Request commit message starts with Apache NiFi Jira issue number, as such NIFI-00000

Pull Request Formatting

  • Pull Request based on current revision of the main branch
  • Pull Request refers to a feature branch with one commit containing changes

Verification

Please indicate the verification steps performed prior to pull request creation.

Build

  • Build completed using mvn clean install -P contrib-check
    • JDK 21

Licensing

  • New dependencies are compatible with the Apache License 2.0 according to the License Policy
  • New dependencies are documented in applicable LICENSE and NOTICE files

Documentation

  • Documentation formatting appears as expected in rendered files

@briansolo1985 briansolo1985 added the minifi Pull requests that updates minifi/c2 codes label Apr 15, 2024
Copy link
Contributor

@exceptionfactory exceptionfactory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the improvement @briansolo1985. The nifi-registry module is commented out in the root Maven configuration, so that needs to be reverted.

pom.xml Outdated Show resolved Hide resolved
Copy link
Contributor

@exceptionfactory exceptionfactory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the updates @briansolo1985.

Most of the changes look good. I noted one recommend to throw an exception instead of logging a warning for an unparsable port number, since that would be contrary to the expected behavior configured in properties.

@briansolo1985
Copy link
Contributor Author

Incorporated all the review comments, please check the changes.

Copy link
Contributor

@exceptionfactory exceptionfactory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the updates @briansolo1985. The latest version looks good, I just noted one minor typo, and opportunity to capitalize Bootstrap, then this looks ready to go.

}
})
.orElse(0);
CMD_LOGGER.info("Using boostrap listen port {}", parsedBootstrapListenPort);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor spelling correction, wording adjustment recommendation:

Suggested change
CMD_LOGGER.info("Using boostrap listen port {}", parsedBootstrapListenPort);
CMD_LOGGER.info("Bootstrap listen port {}", parsedBootstrapListenPort);

try {
return Integer.parseInt(port);
} catch (NumberFormatException e) {
throw new IllegalArgumentException("Unable to parse bootstrap listen port, please provide a valid port for " + NIFI_BOOTSTRAP_LISTEN_PORT);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor adjustment, recommend capitalizing Bootstrap:

Suggested change
throw new IllegalArgumentException("Unable to parse bootstrap listen port, please provide a valid port for " + NIFI_BOOTSTRAP_LISTEN_PORT);
throw new IllegalArgumentException("Unable to parse Bootstrap listen port, please provide a valid port for " + NIFI_BOOTSTRAP_LISTEN_PORT);

@briansolo1985
Copy link
Contributor Author

Updated the PR, please check and merge if good to go

Copy link
Contributor

@exceptionfactory exceptionfactory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @briansolo1985! The latest version looks good! +1 merging

shubhluck pushed a commit to shubhluck/nifi that referenced this pull request Jun 1, 2024
This closes apache#8648

Signed-off-by: David Handermann <exceptionfactory@apache.org>
shubhluck pushed a commit to shubhluck/nifi that referenced this pull request Jun 1, 2024
This closes apache#8648

Signed-off-by: David Handermann <exceptionfactory@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
minifi Pull requests that updates minifi/c2 codes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants