NUTCH-1932 Automatically remove orphaned pages #211
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
sebastian-nagel
commented
Aug 12, 2017
sebastian-nagel
commented
- apply Markus Jelsma's latest patch, 2016-06-30
- add method orphanedScore(Text, CrawlDatum) to ScoringFilter interface
- complete unit tests for CrawlDb update
lewismc
reviewed
Aug 14, 2017
| * URL of the page | ||
| * @param datum | ||
| * CrawlDatum for page | ||
| * @throws ScoringFilterException |
There was a problem hiding this comment.
I think this 'may' break Javadoc generation if no comment is provided alongside the Exception itself.
There was a problem hiding this comment.
Ok, thanks. However, the current state would require more fixes. @throws ScoringFilterException hasn't a description anywhere, it's even not consistently "declared" in the Javadoc. Let's keep this for a later improvement.
sebastian-nagel
force-pushed
the
NUTCH-1932
branch
from
8493718
to
6979397
Compare
- apply Markus Jelsma's latest patch, 2016-06-30 - add method orphanedScore(Text, CrawlDatum) to ScoringFilter interface - complete unit tests for CrawlDb update
sebastian-nagel
force-pushed
the
NUTCH-1932
branch
from
2206c08
to
e5a11a9
Compare
|
Merged after rebase and squash. |
sebastian-nagel
added a commit
to commoncrawl/nutch
that referenced
this pull request
May 16, 2018
- requires patched crawler-commons library (see crawler-commons#210/apache#211)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.