NUTCH-1806 Delegate processing of URL domains to crawler-commons #816
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- add unit test for URLs without host/domain (cf. NUTCH-2450)
- add unit tests for host names with trailing dot ("www.apache.org.")
- use methods from crawler-commons' EffectiveTldFinder in URLUtil
replacing classed and methods from the org.apache.nutch.util.domain
package
- adapt and extend unit tests
- add tests for URLUtil.getTopLevelDomainName(url)
- changes to the public suffix list since 2014
("xyz" is now a public suffix / ICANN suffix)
- minor API changes
- URLUtil.getDomainName(url) returns the host name
in case no valid public suffix is found
- for Unicode suffixes and TLDs the methods
URLUtil.getDomainSuffix(url) resp.
URLUtil.getTopLevelDomainName(url) now return
the ASCII representation
- complete Javadoc
NUTCH-1942 Remove TopLevelDomain - update DomainStatistics, TLDIndexingFilter and domain URL filters to use the updated methods in URLUtil - remove TLDScoringFilter - remove package org.apache.nutch.util.domain - move DomainStatistics to org.apache.nutch.util - remove configuration files of domain utils
sebastian-nagel
changed the title
- restore previous behavior of URLUtil.getDomainSuffix(...) and getTopLevelDomainName(...) to return null if there is no valid public suffix resp. TLD - unify spelling of top-level domain
sebastian-nagel
deleted the
NUTCH-1942-domain-utils-to-use-crawler-commons
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
and NUTCH-1942 Remove TopLevelDomain
use methods from crawler-commons' EffectiveTldFinder in URLUtil replacing classed and methods from the "org.apache.nutch.util.domain" package
adapt and extend unit tests
update and complete Javadoc
update DomainStatistics, TLDIndexingFilter and domain URL filters to use the updated methods in URLUtil
remove the class TLDScoringFilter. The configuration is bound to the domain-suffixes.xml which wasn't maintained anymore and is now removed
remove package org.apache.nutch.util.domain
move DomainStatistics to org.apache.nutch.util
remove configuration files of domain utils