Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NUTCH-3057 - Fix for index-arbitrary plugin improper retention and us… #819

Merged
merged 1 commit into from
Sep 13, 2024

Conversation

CatChullain
Copy link
Contributor

Fix for NUTCH-3057 where index-arbitrary plugin retained value for a field and erroneously set it to the next field declared in its config stanzas

…e of calculated value for arbitrary field after an exception
@lewismc
Copy link
Member

lewismc commented May 18, 2024

Thanks for reporting @CatChullain i didn’t catch this edge case either when reviewing or testing.
Out curiosity what does your deployment look like? Local or deploy?

@lewismc
Copy link
Member

lewismc commented Jul 14, 2024

Hi @CatChullain please send an email to me directly at lewismc [at] apache [dot] org. We would like to invite to to become a committer to the Nutch project.
Thank you

Copy link
Contributor

@sebastian-nagel sebastian-nagel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 lgtm.

@lewismc lewismc self-requested a review September 13, 2024 00:13
Copy link
Member

@lewismc lewismc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 please merge @CatChullain

@CatChullain CatChullain self-assigned this Sep 13, 2024
@CatChullain CatChullain merged commit e09d40c into apache:master Sep 13, 2024
4 checks passed
@CatChullain
Copy link
Contributor Author

Thanks!

Merged now and resolved the Jira. Delete the fix's branch after the merge? Or wait till after the next public release?

@sebastian-nagel
Copy link
Contributor

Delete the fix's branch after the merge? Or wait till after the next public release?

Even if you delete the underlying branch, all changes and commit in the PR are still visible. So, it's safe to delete the branch now. Otherwise: since the branch is on your repository, it's solely your decision.

@CatChullain
Copy link
Contributor Author

Thanks! Yeah, I see now that it says it's on my repo. I was thinking it was in the project's.

@CatChullain CatChullain deleted the NUTCH-3057 branch September 13, 2024 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants