arch/arm/src/samv7/sam_qencoder.c: add support for GETINDEX ioctl call #12081
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+273
to
+254
| uint32_t new_pos; | ||
| new_pos = sam_tc_getcounter(priv->tch); |
There was a problem hiding this comment.
Suggested change
| uint32_t new_pos; | |
| new_pos = sam_tc_getcounter(priv->tch); | |
| uint16_t new_pos = sam_tc_getcounter(priv->tch); |
There was a problem hiding this comment.
Gain the use of uint32_t is based on the above described overhead with 16-bit operations on ARM and x86.
| ****************************************************************************/ | ||
|
|
||
| static inline int32_t sam_qe_pos_16to32b(struct qe_lowerhalf_s *lower, | ||
| uint32_t current_pos) |
There was a problem hiding this comment.
Suggested change
| uint32_t current_pos) | |
| uint16_t current_pos) |
There was a problem hiding this comment.
Gain, I expect no gain there
| ****************************************************************************/ | ||
|
|
||
| static inline int32_t sam_qe_indx_pos_16to32b(struct qe_lowerhalf_s *lower, | ||
| uint32_t current_indx_pos) |
There was a problem hiding this comment.
Suggested change
| uint32_t current_indx_pos) | |
| uint16_t current_indx_pos) |
acassis
reviewed
Apr 9, 2024
|
I'm sorry for my inactivity, however I'm considering everything and I'll look into it further at the end of this week. Thanks for feedback. |
Don't worry! The most important is getting it working correctly! |
zdebanos
force-pushed
the
samv7-qencoder-getindex
branch
from
49cf972
to
005fd52
Compare
The SAMV7's qencoder driver now supports the GETINDEX ioctl call which does not reset the internal Timer/Counter and returns the current position, position of the last index and the number of captured indexes to a struct qe_index_s pointer. Because the SAMV7's timers are 16bit, the extension to 32 bits must be done. Select CONFIG_SAMV7_QENCODER_ENABLE_GETINDEX in the Kconfig to enable this functionality. This driver does not obey the instructions given in the ATSAMV7 2023 datasheet because the recommended trigger resets the internal counter which is not desired. Instead, a capture into capture A and capture B registers is used. This way if an event happens (the rising edge of the index signal), the current counter's value is captured. Signed-off-by: Stepan Pressl <pressste@fel.cvut.cz>
zdebanos
force-pushed
the
samv7-qencoder-getindex
branch
from
005fd52
to
5114bb3
Compare
xiaoxiang781216
approved these changes
Apr 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The SAMV7's qencoder driver now supports the GETINDEX ioctl call which does not reset the internal Timer/Counter and returns the current position, position of the last index and the number of captured indexes to a struct qe_index_s pointer. Because the SAMV7's timers are 16bit, the extension to 32 bits must be done.
Select CONFIG_SAMV7_QENCODER_ENABLE_GETINDEX in the Kconfig to enable this functionality.
This driver does not obey the instructions given in the ATSAMV7 2023 datasheet because the recommended trigger resets the internal counter which is not desired. Instead, a capture into capture A and capture B registers is used. This way if an event happens (the rising edge of the index signal), the current counter's value is captured.