Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

irq: irq_cpu_locked can be remove #12114

Merged
merged 1 commit into from
Apr 12, 2024
Merged

Conversation

hujun260
Copy link
Contributor

Summary

All irq_cpu_locked is called in the critical_section, and the parameter is the current cpu id.
so it must return false, We can safely delete.

Impact

Testing

…rameter is the current cpu id.

so it must return false, We can safely delete.

Signed-off-by: hujun5 <hujun5@xiaomi.com>
@acassis
Copy link
Contributor

acassis commented Apr 10, 2024

Strange, libmetal is failing! Maybe we should fallback to librock :-D

@masayuki2009
Copy link
Contributor

@hujun260

Please describe which configurations and applications you tested.

@hujun260
Copy link
Contributor Author

@hujun260

Please describe which configurations and applications you tested.

This patch will affect all SMP archs. We have tested it on multi-core scenarios using QEMU's arm64, as well as on other hardware platforms。

Compilation Command:
make distclean -j20; ./tools/configure.sh -l qemu-armv8a:nsh_smp ;make -j20

Running Command:
qemu-system-aarch64 -cpu cortex-a53 -smp 4 -nographic -machine virt,virtualization=on,gic-version=3 -net none -chardev stdio,id=con,mux=on -serial chardev:con -mon chardev=con,mode=readline -kernel ./nuttx

@xiaoxiang781216 xiaoxiang781216 merged commit 82acf6e into apache:master Apr 12, 2024
26 checks passed
@hujun260 hujun260 deleted the apache_2 branch April 14, 2024 02:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants