esp32s3: add simple boot support #12165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Simple Boot feature for Espressif chips is a method of booting that doesn't depend on a 2nd stage bootloader. Its not the intention to replace a 2nd stage bootloader such as MCUboot and ESP-IDF bootloader, but to have a minimal and straight-forward way of booting, and also simplify the building. This commit also removes deprecated code and makes this bootloader configuration as default for esp32s3 targets and removes the need for running 'make bootloader' command for it. Other related fix, but not directly to Simple Boot: - Instrumentation is required to run from IRAM to support it during initialization. `is_eco0` function also needs to run from IRAM. - `rtc.data` section placement was fixed. - Provide arch-defined interfaces for efuses, in order to decouple board config level from arch-defined values. Signed-off-by: Almir Okato <almir.okato@espressif.com>
tmedicci
approved these changes
Apr 17, 2024
xiaoxiang781216
approved these changes
Apr 17, 2024
|
@almir-okato have you tested CONFIG_ESP32S3_APP_FORMAT_LEGACY=y with this patch? |
|
@almir-okato is this supposed to work for esp32s3 with 32MB flash? i've got: i can use the same board with ESP32S3_APP_FORMAT_LEGACY. |
yamt
reviewed
May 15, 2024
|
|
||
| /* ------------------Enable Cache----------------------------------- */ | ||
|
|
||
| cache_hal_enable(CACHE_TYPE_ALL); |
There was a problem hiding this comment.
can these apis (cache_hal_enable/cache_hal_disable) be used w/o calling cache_hal_init?
There was a problem hiding this comment.
Hi @yamt , the cache_hal_init is called from bootloader_init. Same routine is called from MCUboot bootloader.
There was a problem hiding this comment.
Hi @yamt , the
cache_hal_initis called frombootloader_init. Same routine is called from MCUboot bootloader.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The Simple Boot feature for Espressif chips is a method of booting that doesn't depend on a 2nd stage bootloader. Its not the intention to replace a 2nd stage bootloader such as MCUboot and ESP-IDF bootloader, but to have a minimal and straight-forward way of booting, and also simplify the building.
This commit also removes deprecated code and makes this bootloader configuration as default for esp32s3 targets and removes the need for running 'make bootloader' command for it.
Other related fix, but not directly to Simple Boot:
is_eco0function also needs to run from IRAM.rtc.datasection placement was fixed.Impact
ESP32-S3 targets and bootloader.
Testing
Internal CI testing