Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

drivers/serial/uart_pl011.c : add the interface about clock and reset control. #12443

Conversation

TakuyaMiyasita
Copy link
Contributor

Summary

I want to add the interface about clock and reset control for reducing power consumption.
I added the pl011_platform_shutdown() / _setup(), these functions are called when pl011_shutdown() / _setup() are called.

The added interface is inteneded as bellows.

  • The pl011_platform_shutdown() is for clock off and reset-asserted.
  • The pl011_platform_setup() is for clock on and reset-de-asserted.

and

This PR includes as following fixes.

  • bug fix about the function : pl011_txready().
  • add the bitmask according to PL011 spec. (Although almost no problem)

Impact

The user of drivers/serial/uart_pl011.c
I think almost no impact as long as do not use CONFIG_UART_PL011_PLATFORMIF.

Testing

I checked following items with our out-of-tree Board directory, some apps and cxd32xx. (The PR of cxd32xx have not accepted yet.)

  • Boot NuttShell(NSH)
  • Passs the "apps/testing/ostest"

Copy link
Contributor

@jerpelea jerpelea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add commit message describing the change

@xiaoxiang781216 xiaoxiang781216 merged commit d644548 into apache:master Jun 3, 2024
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants