up_backtrace: fix maybe backtrace the exiting thread #12754
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anchao
reviewed
Jul 25, 2024
jasonbu
force-pushed
the
backtrace
branch
2 times, most recently
from
27f7b71
to
9da7d30
Compare
xiaoxiang781216
approved these changes
Jul 25, 2024
jerpelea
approved these changes
Jul 25, 2024
when the thread to backtrace is exiting, get_tcb and up_backtrace in different critical section may cause try to dump invalid pointer, have to ensure the nxsched_get_tcb and up_backtrace inside same critical section procedure. Signed-off-by: buxiasen <buxiasen@xiaomi.com>
anchao
approved these changes
Jul 25, 2024
xiaoxiang781216
approved these changes
Jul 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
when trying to show information at task quit and thread still running, try dump callstack found maybe some problem.
Need this patch to solve dump exiting thread callstack. need another patch to fix dump running thread stack.
Impact
Can dump the exiting thread after patch.
Testing
CI & qemu-armv7a & SMP armv7a board.