build: set CMake policy to allow FetchContent_Populate #12880
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FetchContent_Populate is depracated starting from CMake 3.30. Setting this policy to OLD allows clean CMake builds for configurations that rely on CMake fetch content feature. Signed-off-by: Daniel Jasinski <jasinskidaniel95szcz@gmail.com>
simbit18
approved these changes
Aug 10, 2024
xiaoxiang781216
approved these changes
Aug 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
FetchContent_Populate is depracated starting from CMake 3.30. Setting this policy to OLD allows clean (no warnings) CMake builds for configurations that rely on CMake fetch content feature.
Impact
If we want to keep up with CMake versioning - FetchContent_Populate is deprecated in 3.30 - and it's gonna be disabled in future version.
https://cmake.org/cmake/help/latest/module/FetchContent.html#command:fetchcontent_populate
Testing
Local builds (or rather configure steps) using CMake 3.30.2
Was there any specific reason for calling FetchContent_Populate instead of FetchContent_MakeAvailable?