Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rndis: correct usb descriptor #13251

Merged
merged 1 commit into from
Sep 3, 2024
Merged

rndis: correct usb descriptor #13251

merged 1 commit into from
Sep 3, 2024

Conversation

yangsong8-ai
Copy link
Contributor

@yangsong8-ai yangsong8-ai commented Aug 30, 2024

Summary

Fix the regression from #13190

Impact

Testing

@xiaoxiang781216
Copy link
Contributor

@masayuki2009 please try whether this patch can fix your problem.

drivers/usbdev/rndis.c Outdated Show resolved Hide resolved
drivers/usbdev/rndis.c Outdated Show resolved Hide resolved
drivers/usbdev/rndis.c Outdated Show resolved Hide resolved
@masayuki2009
Copy link
Contributor

@yangsong8-ai

Hmm, I tried your branch but it still does not work.

NuttShell (NSH)
nsh> uname -a
NuttX  0.0.0 83d7255f44 Aug 31 2024 08:55:49 arm spresense
nsh> ps
  PID GROUP PRI POLICY   TYPE    NPX STATE    EVENT     SIGMASK           STACK   USED  FILLED COMMAND
    0     0   0 FIFO     Kthread   - Ready              0000000000000000 001008 000512  50.7%  Idle_Task
    1     0 224 RR       Kthread   - Waiting  Semaphore 0000000000000000 001984 000312  15.7%  hpwork 0x2d05ce88 0x2d05ceac
    2     0 100 RR       Kthread   - Waiting  Semaphore 0000000000000000 001984 000312  15.7%  lpwork 0x2d05ce50 0x2d05ce74
    3     3 100 RR       Task      - Running            0000000000000000 003032 001240  40.8%  spresense_main
    4     4 200 RR       Task      - Waiting  MQ empty  0000000000000000 000984 000464  47.1%  cxd56_pm_task
    6     6 100 RR       Task      - Waiting  Semaphore 0000000000000000 002016 000632  31.3%  telnetd
nsh> free
                 total       used       free    maxused    maxfree  nused  nfree
      Umem:    1131436      42596    1088840      43928    1087880    105      2
nsh> ifconfig
lo	Link encap:Local Loopback at RUNNING mtu 1518
	inet addr:127.0.0.1 DRaddr:127.0.0.1 Mask:255.0.0.0

eth0	Link encap:Ethernet HWaddr 00:e0:de:ad:be:ff at UP mtu 1500
	inet addr:10.0.0.2 DRaddr:10.0.0.1 Mask:255.255.255.0

             IPv4   TCP   UDP  ICMP
Received     0000  0000  0000  0000
Dropped      0000  0000  0000  0000
  IPv4        VHL: 0000   Frg: 0000
  Checksum   0000  0000  0000  ----
  TCP         ACK: 0000   SYN: 0000
              RST: 0000  0000
  Type       0000  ----  ----  0000
Sent         0000  0000  0000  0000
  Rexmit     ----  0000  ----  ----
nsh> ifconfig eth0 10.0.1.20
nsh> ifconfig
lo	Link encap:Local Loopback at RUNNING mtu 1518
	inet addr:127.0.0.1 DRaddr:127.0.0.1 Mask:255.0.0.0

eth0	Link encap:Ethernet HWaddr 00:e0:de:ad:be:ff at UP mtu 1500
	inet addr:10.0.1.20 DRaddr:10.0.1.1 Mask:255.255.255.0

             IPv4   TCP   UDP  ICMP
Received     0000  0000  0000  0000
Dropped      0000  0000  0000  0000
  IPv4        VHL: 0000   Frg: 0000
  Checksum   0000  0000  0000  ----
  TCP         ACK: 0000   SYN: 0000
              RST: 0000  0000
  Type       0000  ----  ----  0000
Sent         0000  0000  0000  0000
  Rexmit     ----  0000  ----  ----
nsh> ping -c 10 10.0.1.15
PING 10.0.1.15 56 bytes of data
ERROR: sendto failed at seqno 0: 101
ERROR: sendto failed at seqno 1: 101

@acassis acassis marked this pull request as draft August 31, 2024 15:04
@acassis
Copy link
Contributor

acassis commented Aug 31, 2024

I just converted to Draft to avoid been merged before we get it working

@masayuki2009
Copy link
Contributor

@yangsong8-ai
Thanks for the update. It works now.
However, please change the commit log as follows

drivers: usbdev: Fix USB descriptor

This commit fixes the regression from https://github.com/apache/nuttx/pull/13190

This commit fixes the regression from apache#13190

Signed-off-by: yangsong8 <yangsong8@xiaomi.com>
@yangsong8-ai
Copy link
Contributor Author

OK, the commit log has been updataed. Thank you.

@acassis acassis merged commit 918ae4c into apache:master Sep 3, 2024
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants