Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rpmsgfs: do NOT access the pointer when do remote ioctl #5844

Merged
merged 1 commit into from
Apr 1, 2022

Conversation

GUIDINGLI
Copy link
Contributor

@GUIDINGLI GUIDINGLI commented Mar 25, 2022

Summary

rpmsgfs: do NOT access the pointer when do remote ioctl

rpmsgfs/rename: fix bug about pathname align with 8bytes

This depends on:
#5892

Impact

rpmsgfs

Testing

VELA

fs/rpmsgfs/rpmsgfs_client.c Outdated Show resolved Hide resolved
fs/rpmsgfs/rpmsgfs_client.c Outdated Show resolved Hide resolved
fs/rpmsgfs/rpmsgfs_client.c Outdated Show resolved Hide resolved
fs/rpmsgfs/rpmsgfs_client.c Outdated Show resolved Hide resolved
fs/rpmsgfs/rpmsgfs_client.c Outdated Show resolved Hide resolved
fs/rpmsgfs/rpmsgfs.h Show resolved Hide resolved
@pkarashchenko
Copy link
Contributor

rpmsgfs/rpmsgfs_client.c: In function 'rpmsgfs_ioctl_handler':
Error: rpmsgfs/rpmsgfs_client.c:176:3: error: implicit declaration of function 'rpmsg_post' [-Werror=implicit-function-declaration]
  176 |   rpmsg_post(ept, &cookie->sem);
      |   ^~~~~~~~~~
rpmsgfs/rpmsgfs_client.c: In function 'rpmsgfs_client_ioctl':
Error: rpmsgfs/rpmsgfs_client.c:506:9: error: implicit declaration of function 'rpmsgfs_get_tx_payload_buffer'; did you mean 'rpmsg_get_tx_payload_buffer'? [-Werror=implicit-function-declaration]
  506 |   msg = rpmsgfs_get_tx_payload_buffer(priv, &space);
      |         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
      |         rpmsg_get_tx_payload_buffer
Error: rpmsgfs/rpmsgfs_client.c:506:7: error: assignment to 'struct rpmsgfs_ioctl_s *' from 'int' makes pointer from integer without a cast [-Werror=int-conversion]
  506 |   msg = rpmsgfs_get_tx_payload_buffer(priv, &space);
      |       ^

Please fix the build

@xiaoxiang781216
Copy link
Contributor

@GUIDINGLI please rebase your patch to fix the ci error

Signed-off-by: ligd <liguiding1@xiaomi.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants