boards/samv7/hsmci: add option to invert card detection pin #8577
Conversation
Cynerd
force-pushed
the
sam-hsmci-cd-invert
branch
from
3d2fd61
to
493043a
Compare
The original code hard-coded card detection to the low when card is inserted and high when not. This might not be true on every board because it depends on the slot and wiring used. The second reason is because it is also possible to detect card with D3 pin pull-up when the slot does not provide dedicated card detection switch. This introduces new argument to the sam_hsmci_initialize to allow invert of card detection pin. It also applies this invert to existing boards as that was the state up to this point.
Cynerd
force-pushed
the
sam-hsmci-cd-invert
branch
from
493043a
to
7f1193a
Compare
| @@ -59,7 +59,7 @@ extern "C" | |||
| ****************************************************************************/ | |||
|
|
|||
| int sam_hsmci_initialize(int slotno, int minor, gpio_pinset_t cdcfg, | |||
| int cdirq); | |||
| int cdirq, bool cdinvert); | |||
There was a problem hiding this comment.
I'm just wondering of this solution as adding define BOARD_HSMCI_CD_STATE to board.h seems to me a chipper solution.
@Cynerd do you have any objections if I will rework the code and remove parameter + new data in favour of CD "inserted" level define in board.h?
There was a problem hiding this comment.
I am ok with that.
Honestly, that was my original version and idea. I ended up on this because the original author probably expected support for multiple SD card slots; that was my explanation for passing card detection pin. In such case, the assumption, when using macro, is that everery slot on the board is wired the same way. I do not have nothing against that assumption. I also not see a board with more than one slot in my vicinity. I only implemented it this way to keep it consistent with already established approach of passing card detection configuration.
In short, go ahead.
There was a problem hiding this comment.
Yeah. If the different slots have different CD level routing on PCB (I can't imagine why that might happen, but still) then define in board.h is definitely a limitation. I think that the issue appeared when I moved code to the common folder, so the CD level was moved out from board specific.
Seems that the current approach is more flexible, let's stick with that for now.
The original code hard-coded card detection to the low when card is inserted and high when not. This might not be true on every board because it depends on the slot and wiring used. The second reason is because it is also possible to detect card with D3 pin pull-up when the slot does not provide dedicated card detection switch.
This introduces new argument to the sam_hsmci_initialize to allow invert of card detection pin. It also applies this invert to existing boards as that was the state up to this point.