boards/sama5d3-xplained: Fix OHCI clock. #8854
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Choose a divider value that matches the description provided within the same header file. Include stddef.h to fix compiler errors because NULL is not defined. Make logs print protocol, vid and pid consistently, (decimal hex hex).
|
Hi @ldube thank you for finding and fixing this issue! I took a look at your github and discovered your iPaq H3800 eCos port (not EcoSport hehehe). That was inspiring, maybe it could be a good device to port NuttX as well. Some years ago (16 to be exact) I installed Linux on it, there are some post here: https://acassis.wordpress.com/?s=iPaq (need to translate from Portuguese to English). |
|
@acassis, I would like to see the iPAQ running NuttX too. If I find an excuse to do the port I will. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Choose a divider value that matches the description provided within the same header file.
Include stddef.h to fix compiler errors because NULL is not defined. Make logs print protocol, vid and pid consistently, (decimal hex hex).
Summary
fixes #8848
The board enumerates a USB driver successfully after this change.
The /dev/sda did not appear before this change.
Impact
The following log message used to print vid/pid in hex. All sama5
boards will now print vid and pid in hex. For example:
usbhost_devdesc: class:0 subclass:0 protocol:0 vid:05dc pid:c75c
Testing
mount -t vfat /dev/sda /mnt and list files on the USB drive successfully.