-
Notifications
You must be signed in to change notification settings - Fork 468
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add username and password support for WebDAV #1323
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly LGTM!
I did some work like this before. webdav acrions test use nginx as service, and nginx can use basic auth. plug-in |
And Actions you can use ftp actions as example |
Nice idea. I'm also considering about adding test to cover this case. But I prefer to add tests in a new PR instead. |
Please make sure that our implementation is correct. Whether or not a service supports basic authentication without a password is a user decision. For example, the user might have configured a webdav service with Nginx this way. |
I have verified that |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot!
I'll deal with |
Exactly! |
I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/
Summary
This PR adds username and password support forWebDAV
Please review the changes, if it's ok I will do the same for
HttpBuilder
#1319 #1237