ci: Pin time <= 0.3.17 until we decide to bump MSRV #1361
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Xuanwo <github@xuanwo.io>
imWildCat
pushed a commit
to imWildCat/opendal
that referenced
this pull request
Feb 17, 2023
* ci: Pin time <= 0.3.17 until we decide to bump MSRV Signed-off-by: Xuanwo <github@xuanwo.io> * Fix build Signed-off-by: Xuanwo <github@xuanwo.io> --------- Signed-off-by: Xuanwo <github@xuanwo.io>
Xuanwo
added a commit
that referenced
this pull request
Feb 19, 2023
* add initial * add list response * add webdav list_response parser * add more response * RFR: making PUT more generic * progress implementatin * add dir_stream * make fields public * finish backend * finish * rename to DirStream * add file header * fix lint * update comments * set_capabilities * address backend feedbacks * refine lock & clean up * fix logic * fix lint: dir_stream.rs * trying to fix * Update src/services/webdav/dir_stream.rs per comment from @ClSlaid Co-authored-by: ClSlaid <cailue@bupt.edu.cn> * dav_ext_methods PROPFIND; * PROPFIND * fix formatting * improve nginx config * Install nginx full Signed-off-by: Xuanwo <github@xuanwo.io> * Fix apt install Signed-off-by: Xuanwo <github@xuanwo.io> * import module Signed-off-by: Xuanwo <github@xuanwo.io> * fix lint * nginx * build relative path * trying to fix self.root * add default depth for propfind * feat: support auth for HttpBackend (#1359) support auth for HttpBackend * feat: Add batch delete support (#1357) * Save work Signed-off-by: Xuanwo <github@xuanwo.io> * Refactor batch operater Signed-off-by: Xuanwo <github@xuanwo.io> * Add docs Signed-off-by: Xuanwo <github@xuanwo.io> * Add behavior test Signed-off-by: Xuanwo <github@xuanwo.io> * Format code Signed-off-by: Xuanwo <github@xuanwo.io> * Fix test on fs Signed-off-by: Xuanwo <github@xuanwo.io> --------- Signed-off-by: Xuanwo <github@xuanwo.io> * docs: clarify about opendal user defined client (#1356) * docs: clarify opendal user defined client 1. no auto redirection 2. examples for disable it Signed-off-by: ClSlaid <cailue@bupt.edu.cn> * fix: make document test compilable Signed-off-by: ClSlaid <cailue@bupt.edu.cn> --------- Signed-off-by: ClSlaid <cailue@bupt.edu.cn> * fix(webhdfs): should prepend http:// scheme (#1354) * fix(webhdfs): should prepend http:// scheme Signed-off-by: ClSlaid <cailue@bupt.edu.cn> * refact: check scheme existence only on create Signed-off-by: ClSlaid <cailue@bupt.edu.cn> * fmt: make msrv-clippy happy Signed-off-by: ClSlaid <cailue@bupt.edu.cn> --------- Signed-off-by: ClSlaid <cailue@bupt.edu.cn> * ci: Pin time <= 0.3.17 until we decide to bump MSRV (#1361) * ci: Pin time <= 0.3.17 until we decide to bump MSRV Signed-off-by: Xuanwo <github@xuanwo.io> * Fix build Signed-off-by: Xuanwo <github@xuanwo.io> --------- Signed-off-by: Xuanwo <github@xuanwo.io> * ci: Only run service test on changing (#1363) Only run service test on changing Signed-off-by: Xuanwo <github@xuanwo.io> * add auth for propfind * fix list op * fix root path * add xml header * fix prop xml * remove TODO * skip current path while listing * handle 404 for dir * add MKCOL to fix mkdir * add MKCOL for dirs * end * create dir recursively * handle StatusCode::METHOD_NOT_ALLOWED * fix iteration * fix typo * fix dir creation * fix write --------- Signed-off-by: Xuanwo <github@xuanwo.io> Signed-off-by: ClSlaid <cailue@bupt.edu.cn> Co-authored-by: ClSlaid <cailue@bupt.edu.cn> Co-authored-by: Xuanwo <github@xuanwo.io> Co-authored-by: Young-Flash <71162630+Young-Flash@users.noreply.github.com>
|
Hello. I am a bit curious about the rationale of pinning the version here. Since we commit Cargo.lock into opendal's git history, we get the full control of what version we want. It is not necessary to lock downstream user only because our MSRV policy doesn't meet time's. It might be inconvient when running |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/
Summary
ci: Pin time <= 0.3.17 until we decide to bump MSRV
Related to time-rs/time#551