-
Notifications
You must be signed in to change notification settings - Fork 463
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(services/sftp): change default root config to remote server setting #2431
fix(services/sftp): change default root config to remote server setting #2431
Conversation
Signed-off-by: silver-ymz <yinmingzhuo@gmail.com>
It is intended that the
We can mention this in |
Signed-off-by: silver-ymz <yinmingzhuo@gmail.com>
Signed-off-by: silver-ymz <yinmingzhuo@gmail.com>
Update:
The default root path in About the github action test, because Could you make a review about it? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly LGTM!
Signed-off-by: silver-ymz <yinmingzhuo@gmail.com>
All review suggestions have accepted. Could you make the final review? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Previously, sftp root config only supports absolute path. This patch is mentioned in #2192.