Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: call flush before sync_all #3053

Merged
merged 1 commit into from
Sep 13, 2023
Merged

fix: call flush before sync_all #3053

merged 1 commit into from
Sep 13, 2023

Conversation

WenyXu
Copy link
Member

@WenyXu WenyXu commented Sep 13, 2023 •
edited
Loading

According to tokio-rs/tokio#6005 (comment), We should call flush before sync_all

Related: #3052

@WenyXu WenyXu requested a review from Xuanwo as a code owner September 13, 2023 10:05
@Xuanwo
Copy link
Member

Xuanwo commented Sep 13, 2023

Wow, I used to thought sync_all will cover flush.

Xuanwo
Xuanwo approved these changes Sep 13, 2023
View reviewed changes
Copy link
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Xuanwo Xuanwo merged commit 7d5524f into apache:main Sep 13, 2023
26 of 28 checks passed
@WenyXu
Copy link
Member Author

WenyXu commented Sep 13, 2023

Wow, I used to thought sync_all will cover flush.

Me too, I'm also surprised.

@WenyXu WenyXu mentioned this pull request Sep 13, 2023
Closed
@Xuanwo Xuanwo mentioned this pull request Sep 14, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Xuanwo Xuanwo Xuanwo approved these changes

Assignees
No one assigned
Labels
releases-note/fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@WenyXu @Xuanwo