Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(services/obs): Rewrite method signatures using OpWrite #3075

Merged
merged 1 commit into from
Sep 14, 2023
Merged

feat(services/obs): Rewrite method signatures using OpWrite #3075

merged 1 commit into from
Sep 14, 2023

Conversation

hanxuanliang
Copy link
Contributor

Complete the refactoring code for the obs part of this issue: #3064 .

Xuanwo
Xuanwo approved these changes Sep 14, 2023
View reviewed changes
Copy link
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks a lot! I noticed that the OpRead and OpStat could also be refactor. Would you like to give them a try?

@Xuanwo Xuanwo merged commit 4fac295 into apache:main Sep 14, 2023
29 checks passed
@Xuanwo Xuanwo mentioned this pull request Sep 14, 2023
Closed
13 tasks
@hanxuanliang
Copy link
Contributor Author

Great, thanks a lot! I noticed that the OpRead and OpStat could also be refactor. Would you like to give them a try?

OK. I continue to refactor this part.

@hanxuanliang hanxuanliang deleted the feat/update-obs-req-method branch September 16, 2023 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Xuanwo Xuanwo Xuanwo approved these changes

Assignees
No one assigned
Labels
releases-note/feat
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hanxuanliang @Xuanwo