readers: Allow config prefetch size #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Xuanwo <github@xuanwo.io>
BohuTANG
reviewed
Feb 18, 2022
| use futures::io::BufReader; | ||
| use futures::io::Cursor; | ||
| use futures::{io, AsyncSeekExt}; |
There was a problem hiding this comment.
Make the code style same as other repos style?
Such as databend:
https://github.com/datafuselabs/databend/blob/main/rustfmt.toml
There is no standard here, but defined a style may be important for the contributor to follow :)
There was a problem hiding this comment.
I tried to add imports_granularity = "Item", but it requires nightly rustfmt. And opendal is designed to be used in stable rust 😢
I will fix those styles by hand for now and keep the rustfmt.toml the same with other repos once those options are ready.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Xuanwo github@xuanwo.io
I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/.
Summary
The default prefetch may not be suitable for every use case. Allowing config prefetch size will make the seekable reader more tunable.