Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(services/s3): omit default ports #4379

Merged
merged 3 commits into from
Mar 21, 2024
Merged

Conversation

yufan022
Copy link
Contributor

try fix #4249

The default port is omitted by Url::from(xx) when sending request:

let mut req_builder = self
.client
.request(
parts.method,
reqwest::Url::from_str(&uri.to_string()).expect("input request url must be valid"),
)
.headers(parts.headers);

They are not ignored when calculating signatures:

let url = format!("{}/{}", self.endpoint, percent_encode_path(&p));
let mut req = Request::put(&url);

@yufan022 yufan022 requested a review from Xuanwo as a code owner March 18, 2024 18:09
@yufan022 yufan022 marked this pull request as draft March 18, 2024 19:03
@yufan022 yufan022 marked this pull request as ready for review March 19, 2024 16:01
Copy link
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot!

@Xuanwo Xuanwo merged commit 7c3d8f8 into apache:main Mar 21, 2024
59 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Permission denied if S3 host contains :80
2 participants