fix(services/s3): omit default ports #4379
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
try fix #4249
The default port is omitted by Url::from(xx) when sending request:
opendal/core/src/raw/http_util/client.rs
Lines 89 to 95 in 4c1752b
They are not ignored when calculating signatures:
opendal/core/src/services/s3/core.rs
Lines 382 to 384 in 4c1752b