Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: improve Node.js binding's test doc #5159

Merged
merged 4 commits into from
Oct 6, 2024
Merged

docs: improve Node.js binding's test doc #5159

merged 4 commits into from
Oct 6, 2024

Conversation

tisonkun
Copy link
Member

@tisonkun tisonkun commented Oct 5, 2024

AS IS

@tisonkun
docs: improve Node.js binding's test doc
3cbbae2 
Signed-off-by: tison <wander4096@gmail.com>
@tisonkun tisonkun requested review from Xuanwo and removed request for messense, Zheaoli and suyanhanx October 5, 2024 02:38
@tisonkun
for vscode integration
2fc8276 
Signed-off-by: tison <wander4096@gmail.com>
@tisonkun
fix build unstable
380b9cc 
Signed-off-by: tison <wander4096@gmail.com>
@tisonkun
Merge branch 'main' into nodejs-readme
731e676
suyanhanx
suyanhanx approved these changes Oct 6, 2024
View reviewed changes
Copy link
Member

@suyanhanx suyanhanx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@tisonkun tisonkun merged commit 83a05b9 into main Oct 6, 2024
70 checks passed
@tisonkun tisonkun deleted the nodejs-readme branch October 6, 2024 03:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@suyanhanx suyanhanx suyanhanx approved these changes

@Xuanwo Xuanwo Awaiting requested review from Xuanwo

Assignees
No one assigned
Labels
releases-note/docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tisonkun @suyanhanx