OPENJPA-2730 Update to ASM 6 #11
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM: @rmannibucau or @struberg do you see any issue for ASM upgrade? |
|
yes, the ASM constant was not updated (see https://github.com/jgallimore/openjpa/blob/211cea18b34afe66a8c4d91d03db48a44d0be1d3/openjpa-kernel/src/main/java/org/apache/openjpa/enhance/AsmAdaptor.java#L119 for instance). Once done you can merge @ilgrosso |
|
thanks @rmannibucau / please @jgallimore make the changes requested Does it make sense to merge this PR to |
|
Think so yes |
|
Thanks, I'll update that. I have the change for 2.4.x too. |
Cool :-) |
|
Updated, and also submitted #12 for 2.4.x. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.