Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OPENJPA-2730 Update to ASM 6 #11

Closed
wants to merge 2 commits into from

Conversation

@jgallimore
Copy link

commented Mar 14, 2018

No description provided.

@ilgrosso

This comment has been minimized.

Copy link
Member

commented Mar 14, 2018

LGTM: @rmannibucau or @struberg do you see any issue for ASM upgrade?

@rmannibucau

This comment has been minimized.

Copy link
Contributor

commented Mar 14, 2018

@ilgrosso

This comment has been minimized.

Copy link
Member

commented Mar 14, 2018

thanks @rmannibucau / please @jgallimore make the changes requested

Does it make sense to merge this PR to 2.4.x as well? For instance, is ASM 6 compatible with Java 7?

@rmannibucau

This comment has been minimized.

Copy link
Contributor

commented Mar 14, 2018

Think so yes

@jgallimore

This comment has been minimized.

Copy link
Author

commented Mar 14, 2018

Thanks, I'll update that. I have the change for 2.4.x too.

@ilgrosso

This comment has been minimized.

Copy link
Member

commented Mar 14, 2018

I have the change for 2.4.x too

Cool :-)

@jgallimore

This comment has been minimized.

Copy link
Author

commented Mar 14, 2018

Updated, and also submitted #12 for 2.4.x.

@asfgit asfgit closed this in 5700102 Mar 14, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.