Add support for PHP 7.2 runtime #3736

akrabat · 2018-06-08T11:50:44Z

Description

This PR adds PHP 7.2 as a new kind and sets the default PHP runtime to version 7.2.

I have not provided runtime tests here as they are in the runtime-php repository and they are being removed anyway via #3467. I'm not sure which additional tests are needed in this repo.

Related issue and scope

apache/openwhisk-runtime-php#28 needs to be merged and the relevant Docker containers built and uploaded to the Docker Hub first.

My changes affect the following components

Types of changes

Bug fix (generally a non-breaking change which closes an issue).
Enhancement or new feature (adds new functionality).
Breaking change (a bug fix or enhancement which changes existing behavior).

Checklist:

I signed an Apache CLA.
I reviewed the style guides and followed the recommendations (Travis CI will check :).
I added tests to cover my changes.
My changes require further changes to the documentation.
I updated the documentation where necessary.

rabbah · 2018-06-11T05:13:13Z

actionRuntimes/php7.2Action/Dockerfile

+# Licensed to the Apache Software Foundation (ASF) under one or more contributor
+# license agreements; and to You under the Apache License, Version 2.0.
+
+FROM openwhisk/action-php-v7.2:latest


#3680 and #3745 will eschew this.

rabbah · 2018-06-11T05:13:20Z

actionRuntimes/php7.2Action/build.gradle

@@ -0,0 +1,19 @@
+/*


#3680 and #3745 will eschew this.

rabbah · 2018-06-11T05:13:47Z

ansible/files/runtimes.json

+                "default": true,
+                "deprecated": false,
+                "image": {
+                    "name": "action-php-v7.2"


due to #3680, this should specify the prefix as openwhisk and the tag as latest.

rabbah · 2018-06-11T05:13:56Z

settings.gradle

@@ -28,6 +28,7 @@ include 'actionRuntimes:swift3.1.1Action'
 include 'actionRuntimes:swift4.1Action'
 include 'actionRuntimes:javaAction'
 include 'actionRuntimes:php7.1Action'
+include 'actionRuntimes:php7.2Action'


#3680 and #3745 will eschew this.

rabbah · 2018-06-11T05:14:00Z

tools/build/redo

@@ -309,6 +309,11 @@ Components = [
                  yaml = False,
                  gradle = 'actionRuntimes:php7.1Action'),

+    makeComponent('action-php-v7.2',


#3680 and #3745 will eschew this.

rabbah

both noted PRs are now committed eschewing several files in this PR.

csantanapr · 2018-06-23T14:16:40Z

@akrabat
Can you take another look.
To add PHP 7.2 new kind only need 3 things:

Update ansible/files/runtimes.json with the new entry and make it default, make 7.1 default false
Update the docs with the new php 7.2 info in actions and reference.
Update the swagger docs kinds

akrabat · 2018-06-23T15:11:05Z

What do I need to do in redo?

Also, do I need to update runtimes.manifest in whisk.properties?

akrabat · 2018-06-23T15:15:00Z

Rebased against latest master.

csantanapr · 2018-06-23T15:16:02Z

My bad remove redo changes

csantanapr · 2018-06-23T15:17:39Z

whisk.properties is generated file
“wskdev props” will run ansible properties.yml playbook

rabbah · 2018-06-23T15:19:31Z

Wdyt about giving each of the runtimes their own md file?

akrabat · 2018-06-23T15:28:02Z

Wdyt about giving each of the runtimes their own md file?

I think reorganising actions.md & reference.md to an md per action makes a lot of sense.

csantanapr · 2018-06-23T15:30:59Z

@rabbah @akrabat
I think we need to add a system basic tests for the new kind
I should assume that php 7.2 kind might not be installed so we don’t brake deployments pipeline that have not picked the new kind yet.

@rabbah I think you mentioned you wanted to refactor the basic and Unicode tests to run based on what the runtime manifest States is deployed ?

csantanapr · 2018-06-23T15:52:39Z

Yeah braking the docs per kind runtime is on my personal TODOs
But help is welcome 😸

There might be duplication, but I think is ok for us(ie maintainers) to deal with the duplication effort (or automation) and end users to benefit of taking a single md file from top to bottom and only deal with the programming language they are dealing and not assume they read the JavaScript examples.
Also another item in TODOs
For each kind to have a section on how to extend a runtime when they deal with large zips or they want to have one runtime with the dependencies or libraries across all the functions in an app

codecov-io · 2018-06-23T16:07:49Z

Codecov Report

Merging #3736 into master will decrease coverage by 3.47%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #3736      +/-   ##
==========================================
- Coverage   74.76%   71.28%   -3.48%     
==========================================
  Files         137      139       +2     
  Lines        6440     6767     +327     
  Branches      401      426      +25     
==========================================
+ Hits         4815     4824       +9     
- Misses       1625     1943     +318

Impacted Files	Coverage Δ
...c/main/scala/whisk/core/database/UserCommand.scala	`61.11% <0%> (-36.67%)`	⬇️
...rpool/logging/DockerToActivationFileLogStore.scala	`46.77% <0%> (-31.61%)`	⬇️
...a/whisk/core/loadBalancer/InvokerSupervision.scala	`59.3% <0%> (-22.96%)`	⬇️
...la/src/main/scala/whisk/core/entity/Identity.scala	`73.52% <0%> (-19.07%)`	⬇️
...cala/whisk/core/containerpool/ContainerProxy.scala	`77.77% <0%> (-14.23%)`	⬇️
...e/loadBalancer/ShardingContainerPoolBalancer.scala	`18.96% <0%> (-13.58%)`	⬇️
...ain/scala/whisk/core/containerpool/HttpUtils.scala	`42.62% <0%> (-8.36%)`	⬇️
...rc/main/scala/whisk/core/controller/Triggers.scala	`77.62% <0%> (-3.4%)`	⬇️
...on/scala/src/main/scala/whisk/common/Logging.scala	`86% <0%> (-1.78%)`	⬇️
...whisk/core/entity/BasicAuthenticationAuthKey.scala	`28.57% <0%> (ø)`
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b1476b9...6b9d0f8. Read the comment docs.

Version numbers corrected by checking the composer.json in the openwhisk-runtime-php repository.

akrabat · 2018-07-01T19:05:40Z

Updated and rebased for the updated docs structure.

csantanapr · 2018-07-03T14:54:35Z

PG1 3094 ⌛️

rabbah · 2018-07-03T15:16:18Z

core/controller/src/main/resources/apiv1swagger.json

@@ -1499,6 +1499,8 @@
                        "nodejs:8",
                        "python:2",
                        "python:3",
+                        "php:7.1",
+                        "php:7.2",


we'll need to keep this in sync with the runtime manifest in general.

csantanapr · 2018-07-03T17:11:11Z

Playground1/3096/ 🔵

csantanapr · 2018-06-23T15:18:51Z

core/controller/src/main/resources/apiv1swagger.json

@@ -1499,6 +1499,8 @@
                        "nodejs:8",
                        "python:2",
                        "python:3",
+                        "php:7.1",


I forgot about swagger 👍

now PR in sync

akrabat force-pushed the php-7.2 branch from c358b54 to a007403 Compare June 8, 2018 16:02

rabbah added the runtime label Jun 11, 2018

rabbah reviewed Jun 11, 2018

View reviewed changes

rabbah previously requested changes Jun 21, 2018

View reviewed changes

akrabat force-pushed the php-7.2 branch from a007403 to db9dbe9 Compare June 23, 2018 15:11

akrabat added 4 commits July 1, 2018 19:51

Add PHP 7.2 to runtimes.json

ce4cb19

Update Swagger definition with PHP kinds

04c23f7

Update docs for PHP 7.2

df6f2ce

Correct version numbers of Composer packages

6b9d0f8

Version numbers corrected by checking the composer.json in the openwhisk-runtime-php repository.

akrabat force-pushed the php-7.2 branch from db9dbe9 to 6b9d0f8 Compare July 1, 2018 19:04

akrabat closed this Jul 2, 2018

akrabat reopened this Jul 2, 2018

rabbah reviewed Jul 3, 2018

View reviewed changes

csantanapr approved these changes Jul 3, 2018

View reviewed changes

csantanapr merged commit ebf42b2 into apache:master Jul 3, 2018

BillZong pushed a commit to BillZong/openwhisk that referenced this pull request Nov 18, 2019

Add support for PHP 7.2 runtime (apache#3736)

1d1ff70

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add support for PHP 7.2 runtime #3736

Add support for PHP 7.2 runtime #3736

akrabat commented Jun 8, 2018

rabbah Jun 11, 2018

rabbah Jun 11, 2018

rabbah Jun 11, 2018

rabbah Jun 11, 2018

rabbah Jun 11, 2018

rabbah left a comment

csantanapr commented Jun 23, 2018 •

edited

Loading

akrabat commented Jun 23, 2018

akrabat commented Jun 23, 2018

csantanapr commented Jun 23, 2018

csantanapr commented Jun 23, 2018

rabbah commented Jun 23, 2018

akrabat commented Jun 23, 2018

csantanapr commented Jun 23, 2018

csantanapr commented Jun 23, 2018 •

edited

Loading

codecov-io commented Jun 23, 2018 •

edited

Loading

akrabat commented Jul 1, 2018

csantanapr commented Jul 3, 2018 •

edited

Loading

rabbah Jul 3, 2018

csantanapr commented Jul 3, 2018

csantanapr Jun 23, 2018

Add support for PHP 7.2 runtime #3736

Add support for PHP 7.2 runtime #3736

Conversation

akrabat commented Jun 8, 2018

Description

Related issue and scope

My changes affect the following components

Types of changes

Checklist:

rabbah Jun 11, 2018

Choose a reason for hiding this comment

rabbah Jun 11, 2018

Choose a reason for hiding this comment

rabbah Jun 11, 2018

Choose a reason for hiding this comment

rabbah Jun 11, 2018

Choose a reason for hiding this comment

rabbah Jun 11, 2018

Choose a reason for hiding this comment

rabbah left a comment

Choose a reason for hiding this comment

csantanapr commented Jun 23, 2018 • edited Loading

akrabat commented Jun 23, 2018

akrabat commented Jun 23, 2018

csantanapr commented Jun 23, 2018

csantanapr commented Jun 23, 2018

rabbah commented Jun 23, 2018

akrabat commented Jun 23, 2018

csantanapr commented Jun 23, 2018

csantanapr commented Jun 23, 2018 • edited Loading

codecov-io commented Jun 23, 2018 • edited Loading

Codecov Report

akrabat commented Jul 1, 2018

csantanapr commented Jul 3, 2018 • edited Loading

rabbah Jul 3, 2018

Choose a reason for hiding this comment

csantanapr commented Jul 3, 2018

csantanapr Jun 23, 2018

Choose a reason for hiding this comment

csantanapr commented Jun 23, 2018 •

edited

Loading

csantanapr commented Jun 23, 2018 •

edited

Loading

codecov-io commented Jun 23, 2018 •

edited

Loading

csantanapr commented Jul 3, 2018 •

edited

Loading