Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add swift:5.1 kind to runtimes.json #4803

Merged
merged 2 commits into from
Jan 24, 2020
Merged

Add swift:5.1 kind to runtimes.json #4803

merged 2 commits into from
Jan 24, 2020

Conversation

dgrove-oss
Copy link
Member

No description provided.

@codecov-io
Copy link

Codecov Report

Merging #4803 into master will decrease coverage by 6.59%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #4803     +/-   ##
=========================================
- Coverage   85.19%   78.59%   -6.6%     
=========================================
  Files         197      197             
  Lines        8839     8839             
  Branches      619      619             
=========================================
- Hits         7530     6947    -583     
- Misses       1309     1892    +583
Impacted Files Coverage Δ
...core/database/cosmosdb/RxObservableImplicits.scala 0% <0%> (-100%) ⬇️
...enwhisk/connector/kafka/KamonMetricsReporter.scala 0% <0%> (-100%) ⬇️
...e/database/cosmosdb/cache/ChangeFeedConsumer.scala 0% <0%> (-100%) ⬇️
...ore/database/cosmosdb/cache/CacheInvalidator.scala 0% <0%> (-100%) ⬇️
...core/database/cosmosdb/CosmosDBArtifactStore.scala 0% <0%> (-96.23%) ⬇️
...sk/core/database/cosmosdb/CosmosDBViewMapper.scala 0% <0%> (-93.85%) ⬇️
...tabase/cosmosdb/cache/CacheInvalidatorConfig.scala 0% <0%> (-92.31%) ⬇️
...e/database/cosmosdb/cache/KafkaEventProducer.scala 0% <0%> (-77.78%) ⬇️
...whisk/core/database/cosmosdb/CosmosDBSupport.scala 0% <0%> (-74.08%) ⬇️
...abase/cosmosdb/CosmosDBArtifactStoreProvider.scala 7.69% <0%> (-50%) ⬇️
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 51de9d7...f9a2950. Read the comment docs.

@rabbah
Copy link
Member

rabbah commented Jan 24, 2020

Should update the swagger too - will add link.

@dgrove-oss
Copy link
Member Author

Thanks. updated swagger for both Swift 5.1 and .NET 3.1 (was missed when we added .NET 3.1)

@rabbah rabbah merged commit fcbe9ca into apache:master Jan 24, 2020
@dgrove-oss dgrove-oss deleted the swift5 branch January 24, 2020 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants