Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

What's the meaning of EvaluatedRowGroupCount in ReaderMetrics #1829

Closed
Smith-Cruise opened this issue Feb 28, 2024 · 5 comments
Closed

What's the meaning of EvaluatedRowGroupCount in ReaderMetrics #1829

Smith-Cruise opened this issue Feb 28, 2024 · 5 comments

Comments

@Smith-Cruise
Copy link
Contributor

in SargsApplier::pickRowGroups(), EvaluatedRowGroupCount looks like is row group that has been evaluated

but in SargsApplier::evaluateFileStatistics() and SargsApplier::evaluateStripeStatistics(), EvaluatedRowGroupCount looks like is row group has been filtered by Sargs.

I'm little confused, anyone knows about it?
@wgtmac
Copy link
Member

wgtmac commented Feb 28, 2024

Could you help answer this? @coderex2522

@ffacs
Copy link
Contributor

ffacs commented Mar 1, 2024

It seems that there are some bugs in the code that SargsApplier::evaluateFileStatistics() and SargsApplier::evaluateStripeStatistics() didn't count up row groups that has been evaluated correctly.

@Smith-Cruise
Copy link
Contributor Author

It seems that there are some bugs in the code that SargsApplier::evaluateFileStatistics() and SargsApplier::evaluateStripeStatistics() didn't count up row groups that has been evaluated correctly.

I don't know if it's a bug or if it's intentional

@wgtmac
Copy link
Member

wgtmac commented Mar 3, 2024

It should be a bug. Do you want to fix it? @ffacs @Smith-Cruise

@Smith-Cruise
Copy link
Contributor Author

It should be a bug. Do you want to fix it? @ffacs @Smith-Cruise

It's easy to fix, so we need to count row groups even they can be filtered.

@ffacs ffacs mentioned this issue Mar 12, 2024
Closed
@wgtmac wgtmac closed this as completed in e1f185e Mar 14, 2024
wgtmac pushed a commit that referenced this issue Mar 14, 2024
@ffacs @wgtmac
ORC-1654: [C++] Count up EvaluatedRowGroupCount correctly
4eaf306 
### What changes were proposed in this pull request?
Count up EvaluatedRowGroupCount correctly.

### Why are the changes needed?
to fix #1829

### How was this patch tested?
UT passed

### Was this patch authored or co-authored using generative AI tooling?
No

Closes #1844 from ffacs/ORC-1654.

Authored-by: ffacs <ffacs520@gmail.com>
Signed-off-by: Gang Wu <ustcwg@gmail.com>
(cherry picked from commit e1f185e)
Signed-off-by: Gang Wu <ustcwg@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ORC-1654: [C++] Count up EvaluatedRowGroupCount correctly. ffacs/orc
3 participants
@wgtmac @Smith-Cruise @ffacs