ORC-1344: Skip SBOM generation during CMake #1354
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dongjoon-hyun
changed the title
|
cc @williamhyun |
|
Thank you, @williamhyun . Merged to main/1.8/1.7. |
dongjoon-hyun
added a commit
that referenced
this pull request
Jan 9, 2023
### What changes were proposed in this pull request? This PR aims to skip `SBOM` generation during CMake. In the community, Apache ORC release and GitHub Action publishing job uses `mvnw` directly. ### Why are the changes needed? During testing, we don't need SBOM. Only snapshot CI job requires to publish SBOM. ### How was this patch tested? Manually check the log of GitHub Action jobs in this PR. Closes #1354 from dongjoon-hyun/ORC-1344. Authored-by: Dongjoon Hyun <dongjoon@apache.org> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org> (cherry picked from commit 046a03f) Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
dongjoon-hyun
added a commit
that referenced
this pull request
Jan 9, 2023
### What changes were proposed in this pull request? This PR aims to skip `SBOM` generation during CMake. In the community, Apache ORC release and GitHub Action publishing job uses `mvnw` directly. ### Why are the changes needed? During testing, we don't need SBOM. Only snapshot CI job requires to publish SBOM. ### How was this patch tested? Manually check the log of GitHub Action jobs in this PR. Closes #1354 from dongjoon-hyun/ORC-1344. Authored-by: Dongjoon Hyun <dongjoon@apache.org> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org> (cherry picked from commit 046a03f) Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
cxzl25
pushed a commit
to cxzl25/orc
that referenced
this pull request
Jan 11, 2024
### What changes were proposed in this pull request? This PR aims to skip `SBOM` generation during CMake. In the community, Apache ORC release and GitHub Action publishing job uses `mvnw` directly. ### Why are the changes needed? During testing, we don't need SBOM. Only snapshot CI job requires to publish SBOM. ### How was this patch tested? Manually check the log of GitHub Action jobs in this PR. Closes apache#1354 from dongjoon-hyun/ORC-1344. Authored-by: Dongjoon Hyun <dongjoon@apache.org> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR aims to skip
SBOMgeneration during CMake.In the community, Apache ORC release and GitHub Action publishing job uses
mvnwdirectly.Why are the changes needed?
During testing, we don't need SBOM.
Only snapshot CI job requires to publish SBOM.
How was this patch tested?
Manually check the log of GitHub Action jobs in this PR.