Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ORC-1358: Use spotless to format pom files #1386

Closed
wants to merge 1 commit into from

Conversation

dongjoon-hyun
Copy link
Member

What changes were proposed in this pull request?

This is a backport of #1377

This PR aims to use spotless to format pom files.

Why are the changes needed?

This will enforce good style in pom files.

How was this patch tested?

Pass the CIs with newly added plugin.

@dongjoon-hyun
Copy link
Member Author

Could you review this, @williamhyun ? This is a backport of #1377 .

Copy link
Member

@williamhyun williamhyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 LGTM

williamhyun pushed a commit that referenced this pull request Jan 18, 2023
### What changes were proposed in this pull request?
This is a backport of #1377

This PR aims to use [spotless](https://github.com/diffplug/spotless) to format pom files.

### Why are the changes needed?
This will enforce good style in pom files.

### How was this patch tested?
Pass the CIs with newly added plugin.

Closes #1386 from dongjoon-hyun/ORC-1358.

Authored-by: Dongjoon Hyun <dongjoon@apache.org>
Signed-off-by: William Hyun <william@apache.org>
@dongjoon-hyun
Copy link
Member Author

Thank you, @williamhyun !

@dongjoon-hyun dongjoon-hyun deleted the ORC-1358 branch January 19, 2023 02:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants