ORC-313,ORC-317: Check types in footer #225
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stiga-huang
force-pushed
the
check-subtypes
branch
from
8d7a668
to
a134550
Compare
stiga-huang
changed the title
We need to verify the subtype count of LIST and MAP types. Otherwise, the ill types will lead the c++ reader to crash. The java reader also has this problem.
stiga-huang
force-pushed
the
check-subtypes
branch
from
224ba33
to
0f17474
Compare
|
Hi @omalley @majetideepak, this PR is ready for review. Could you have a look? |
|
@stiga-huang can you open a separate PR or each JIRA? Thanks. |
|
@majetideepak OK. When I separate the PR, I found orc-test failed in TestWriter.writeTimestamp (ORC-320). I might need to fix that first. |
|
@majetideepak I opened #229 for ORC-313 |
|
@stiga-huang I will look into these this week. Can you fix the title of this PR? Thanks! |
|
@majetideepak To be clean, I open #231 for ORC-317. I'd like to close this PR. Thanks for your review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to verify the subtype count of LIST and MAP types. Otherwise,
the ill types will lead the c++ reader to crash.
The java reader also has this problem.