Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HDDS-7507. [Snapshot] Implement List Snapshot API Pagination #4065

Merged
merged 11 commits into from
Mar 6, 2023
Merged

HDDS-7507. [Snapshot] Implement List Snapshot API Pagination #4065

merged 11 commits into from
Mar 6, 2023

Conversation

chungen0126
Copy link
Contributor

@chungen0126 chungen0126 commented Dec 12, 2022 •
edited
Loading

What changes were proposed in this pull request?

  1. Implement list snapshot API pagination.
  2. Add some unit test.

What is the link to the Apache JIRA

https://issues.apache.org/jira/browse/HDDS-7507

How was this patch tested?

Added unit test to TestOmMetadataManager.

@DaveTeng0
Copy link
Contributor

Let's take a look~ (cc. @smengcl @hemantk-12 @swamirishi @aswinshakil @prashantpogde

@DaveTeng0
Copy link
Contributor

Hey @chungen0126 ! Just a heads-up that there are some conflicts~

@smengcl smengcl added the snapshot https://issues.apache.org/jira/browse/HDDS-6517 label Feb 12, 2023
prashantpogde
prashantpogde reviewed Feb 16, 2023
View reviewed changes
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OmMetadataManagerImpl.java
private void appendSnapshotFromDBToMap(TreeMap snapshotInfoMap, String prefix)
private void appendSnapshotFromDBToMap(TreeMap snapshotInfoMap,
String prefix, String previous,
int count, int maxListResult)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are just reading from the SnapshotInfo Table here. This may not necessarily be Snapshot creation order/. Can you please check this ?

prashantpogde
prashantpogde reviewed Feb 16, 2023
View reviewed changes
Copy link
Contributor

@prashantpogde prashantpogde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we also write some integration test for this with at least several hundred snapshots created ? The test can also include cases where snapshot creation order doesn't match wit snapshot names lexicographical order.

smengcl
smengcl reviewed Feb 22, 2023
View reviewed changes
Copy link
Contributor

@smengcl smengcl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @chungen0126 . Overall lgtm.

It would be great if we can have at least an integration test to prove that pagination is working in the mini cluster.

prashantpogde
prashantpogde approved these changes Mar 6, 2023
View reviewed changes
Copy link
Contributor

@prashantpogde prashantpogde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @chungen0126 for making these changes. LGTM.

@smengcl smengcl merged commit 9f84c77 into apache:HDDS-6517-Snapshot Mar 6, 2023
@smengcl
Copy link
Contributor

smengcl commented Mar 6, 2023

Thanks @chungen0126 for the patch. Thanks @DaveTeng0 @prashantpogde for reviewing this.

@hemantk-12 hemantk-12 mentioned this pull request Jun 8, 2023
Merged
smengcl pushed a commit to smengcl/hadoop-ozone that referenced this pull request Jun 8, 2023
@chungen0126 @smengcl
HDDS-7507. [Snapshot] Implement List Snapshot API Pagination (apache#…
c26cdbb 
…4065)

(cherry picked from commit 9f84c77)

Conflicts:
hadoop-ozone/client/src/main/java/org/apache/hadoop/ozone/client/ObjectStore.java
hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/client/rpc/TestOzoneRpcClientAbstract.java
@smengcl smengcl mentioned this pull request Jun 8, 2023
Merged
smengcl added a commit that referenced this pull request Jun 9, 2023
@smengcl @chungen0126
HDDS-7507. [Snapshot] Implement List Snapshot API Pagination (#4065) (#…
a94d2fc 
…4861)

Co-authored-by: Chung En Lee <wfps1210@gmail.com>
errose28 added a commit to errose28/ozone that referenced this pull request Jun 10, 2023
@errose28
Merge branch 'master' into tmp-dir-refactor
ccded0a 
* master: (73 commits)
  HDDS-8587. Test that CertificateClient can store multiple rootCA certificates (apache#4852)
  HDDS-8801. ReplicationManager: Add metric to count how often replication is throttled (apache#4864)
  HDDS-8477. Unit test for Snapdiff using tombstone entries (apache#4678)
  HDDS-7507. [Snapshot] Implement List Snapshot API Pagination (apache#4065) (apache#4861)
  HDDS-8373. Document that setquota doesn't accept decimals (apache#4856)
  HDDS-8779. Recon - Expose flag for enable/disable of heatmap. (apache#4845)
  HDDS-8677. Ozone admin OM CLI command for block tokens (apache#4760)
  HDDS-8164. Authorize secret key APIs (apache#4597)
  HDDS-7945. Integrate secret keys to SCM snapshot (apache#4549)
  HDDS-8003. E2E integration test cases for block tokens (apache#4547)
  HDDS-7831. Use symmetric secret key to sign and verify token (apache#4417)
  HDDS-7830. SCM API for OM and Datanode to get secret keys (apache#4345)
  HDDS-7734. Implement symmetric SecretKeys lifescycle management in SCM (apache#4194)
  HDDS-8679. Add dedicated, configurable thread pool for OM gRPC server (apache#4771)
  HDDS-8790. Split EC acceptance tests (apache#4855)
  HDDS-8714. TestScmHAFinalization: mark testFinalizationWithRestart as flaky, enable other test cases
  HDDS-8787. Reduce ozone sh calls in robot tests (apache#4854)
  HDDS-8774. Log allocation stack trace for leaked CodecBuffer (apache#4840)
  HDDS-8729. Add metric for count of blocks pending deletion on datanode (apache#4800)
  HDDS-8780. Leak of ManagedChannel in HASecurityUtils (apache#4850)
  ...
errose28 added a commit to errose28/ozone that referenced this pull request Jun 10, 2023
@errose28
Merge branch 'tmp-dir-refactor' into improve-volume-scanner
b581bc9 
* tmp-dir-refactor: (73 commits)
  HDDS-8587. Test that CertificateClient can store multiple rootCA certificates (apache#4852)
  HDDS-8801. ReplicationManager: Add metric to count how often replication is throttled (apache#4864)
  HDDS-8477. Unit test for Snapdiff using tombstone entries (apache#4678)
  HDDS-7507. [Snapshot] Implement List Snapshot API Pagination (apache#4065) (apache#4861)
  HDDS-8373. Document that setquota doesn't accept decimals (apache#4856)
  HDDS-8779. Recon - Expose flag for enable/disable of heatmap. (apache#4845)
  HDDS-8677. Ozone admin OM CLI command for block tokens (apache#4760)
  HDDS-8164. Authorize secret key APIs (apache#4597)
  HDDS-7945. Integrate secret keys to SCM snapshot (apache#4549)
  HDDS-8003. E2E integration test cases for block tokens (apache#4547)
  HDDS-7831. Use symmetric secret key to sign and verify token (apache#4417)
  HDDS-7830. SCM API for OM and Datanode to get secret keys (apache#4345)
  HDDS-7734. Implement symmetric SecretKeys lifescycle management in SCM (apache#4194)
  HDDS-8679. Add dedicated, configurable thread pool for OM gRPC server (apache#4771)
  HDDS-8790. Split EC acceptance tests (apache#4855)
  HDDS-8714. TestScmHAFinalization: mark testFinalizationWithRestart as flaky, enable other test cases
  HDDS-8787. Reduce ozone sh calls in robot tests (apache#4854)
  HDDS-8774. Log allocation stack trace for leaked CodecBuffer (apache#4840)
  HDDS-8729. Add metric for count of blocks pending deletion on datanode (apache#4800)
  HDDS-8780. Leak of ManagedChannel in HASecurityUtils (apache#4850)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smengcl smengcl smengcl approved these changes

@prashantpogde prashantpogde prashantpogde approved these changes

Assignees
No one assigned
Labels
snapshot https://issues.apache.org/jira/browse/HDDS-6517
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@chungen0126 @DaveTeng0 @smengcl @prashantpogde