Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HDDS-2878. Refactor MiniOzoneLoadGenerator to add more load generators to chaos testing. #438

Merged
merged 6 commits into from
Mar 24, 2020

Conversation

mukul1987
Copy link
Contributor

@mukul1987 mukul1987 commented Jan 12, 2020

What changes were proposed in this pull request?

This jira refactors the current MiniOzoneLoadGenerator to make it more pluggable.

What is the link to the Apache JIRA

https://issues.apache.org/jira/browse/HDDS-2878

How was this patch tested?

Tested by running MiniOzoneChaosCluster.

@mukul1987 mukul1987 changed the title HDDS-2878. Refactor MiniOzoneLoadGenerator to add more load generator… HDDS-2878. Refactor MiniOzoneLoadGenerator to add more load generators to chaos testing. Jan 12, 2020
@mukul1987 mukul1987 marked this pull request as ready for review January 14, 2020 12:23
Copy link
Contributor

@nandakumar131 nandakumar131 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall the change looks good. Some minor comments and questions posted inline.

@elek
Copy link
Member

elek commented Feb 18, 2020

/pending Pending on author to address the comments

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Marking this issue as un-mergeable as requested.

Please use /ready comment when it's resolved.

Pending on author to address the comments

@mukul1987
Copy link
Contributor Author

/ready

@github-actions github-actions bot dismissed their stale review March 15, 2020 18:01

Blocking review request is removed.

Copy link
Contributor

@xiaoyuyao xiaoyuyao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a few minor comments inline...

Copy link
Contributor

@adoroszlai adoroszlai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mukul1987 for refactoring this code. It looks much cleaner than previously.

@mukul1987 mukul1987 force-pushed the HDDS-2878 branch 2 times, most recently from 4bf7b16 to 03206f9 Compare March 23, 2020 14:16
Copy link
Contributor

@adoroszlai adoroszlai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mukul1987 for updating the patch.

@mukul1987 mukul1987 merged commit ad7cd6a into apache:master Mar 24, 2020
@mukul1987 mukul1987 deleted the HDDS-2878 branch March 24, 2020 09:09
isahekmat pushed a commit to isahekmat/hadoop-ozone that referenced this pull request Mar 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants