Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HDDS-10342. Reduce code duplication in MiniOzoneCluster builders #6206

Merged
merged 13 commits into from
Feb 20, 2024
Merged

HDDS-10342. Reduce code duplication in MiniOzoneCluster builders #6206

merged 13 commits into from
Feb 20, 2024

Commits on Feb 9, 2024

  1. extract method to configure and create Recon

    @adoroszlai
    adoroszlai committed Feb 9, 2024
    Configuration menu
    Copy the full SHA
    59286e6 View commit details
    Browse the repository at this point in the history

  2. move setting Recon address to createRecon()

    @adoroszlai
    adoroszlai committed Feb 9, 2024
    Configuration menu
    Copy the full SHA
    927c3dc View commit details
    Browse the repository at this point in the history

  3. extract methods to start single SCM and configure SCM address

    @adoroszlai
    adoroszlai committed Feb 9, 2024
    Configuration menu
    Copy the full SHA
    43e4bd0 View commit details
    Browse the repository at this point in the history

  4. extract method to set cert/secretKey client on OM

    @adoroszlai
    adoroszlai committed Feb 9, 2024
    Configuration menu
    Copy the full SHA
    6925826 View commit details
    Browse the repository at this point in the history

  5. extract method to start single OM

    @adoroszlai
    adoroszlai committed Feb 9, 2024
    Configuration menu
    Copy the full SHA
    e6760a2 View commit details
    Browse the repository at this point in the history

  6. remove unused serviceId accessors

    @adoroszlai
    adoroszlai committed Feb 9, 2024
    Configuration menu
    Copy the full SHA
    b1e0f77 View commit details
    Browse the repository at this point in the history

  7. remove useless javadoc

    @adoroszlai
    adoroszlai committed Feb 9, 2024
    Configuration menu
    Copy the full SHA
    35221e8 View commit details
    Browse the repository at this point in the history

  8. remove unused startScm()

    @adoroszlai
    adoroszlai committed Feb 9, 2024
    Configuration menu
    Copy the full SHA
    aebabf3 View commit details
    Browse the repository at this point in the history

  9. create constant NO_ARGS

    @adoroszlai
    adoroszlai committed Feb 9, 2024
    Configuration menu
    Copy the full SHA
    55d0f41 View commit details
    Browse the repository at this point in the history

  10. unnecessary toString

    @adoroszlai
    adoroszlai committed Feb 9, 2024
    Configuration menu
    Copy the full SHA
    6784b96 View commit details
    Browse the repository at this point in the history

  11. avoid + in append()

    @adoroszlai
    adoroszlai committed Feb 9, 2024
    Configuration menu
    Copy the full SHA
    426c9c3 View commit details
    Browse the repository at this point in the history

  12. reduce visibility

    @adoroszlai
    adoroszlai committed Feb 9, 2024
    Configuration menu
    Copy the full SHA
    c536bd6 View commit details
    Browse the repository at this point in the history

  13. some member variables can be final

    @adoroszlai
    adoroszlai committed Feb 9, 2024
    Configuration menu
    Copy the full SHA
    6f42143 View commit details
    Browse the repository at this point in the history